From owner-cvs-src@FreeBSD.ORG  Thu Sep 29 13:49:09 2005
Return-Path: <owner-cvs-src@FreeBSD.ORG>
X-Original-To: cvs-src@freebsd.org
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id ACCA916A41F
	for <cvs-src@freebsd.org>; Thu, 29 Sep 2005 13:49:09 +0000 (GMT)
	(envelope-from peadar.edwards@gmail.com)
Received: from zproxy.gmail.com (zproxy.gmail.com [64.233.162.205])
	by mx1.FreeBSD.org (Postfix) with ESMTP id EB2B143D49
	for <cvs-src@freebsd.org>; Thu, 29 Sep 2005 13:49:07 +0000 (GMT)
	(envelope-from peadar.edwards@gmail.com)
Received: by zproxy.gmail.com with SMTP id z31so222352nzd
	for <cvs-src@freebsd.org>; Thu, 29 Sep 2005 06:49:07 -0700 (PDT)
DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com;
	h=received:message-id:date:from:reply-to:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references;
	b=m+a03kqIBvhyhyGfCIS0LP4165BERghvGuBX0lFUJsjLcOeDRziGXFjHrc8BOcwhhbx2DuggkjxXKhCQL1EkyhukM/Hj96rObuGPGUF4MXAevPkiV6u1dqdjMfKdKaASfO3EoTii0Q8fSNtHdIvmbeCnErrmvrIvM7ldscK1TdA=
Received: by 10.37.15.4 with SMTP id s4mr1817069nzi;
	Thu, 29 Sep 2005 06:49:07 -0700 (PDT)
Received: by 10.36.68.16 with HTTP; Thu, 29 Sep 2005 06:49:07 -0700 (PDT)
Message-ID: <34cb7c84050929064918862231@mail.gmail.com>
Date: Thu, 29 Sep 2005 14:49:07 +0100
From: Peter Edwards <peadar.edwards@gmail.com>
To: Pawel Jakub Dawidek <pjd@freebsd.org>
In-Reply-To: <20050929130338.GC1715@garage.freebsd.pl>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline
References: <200509291037.j8TAbKdI010227@repoman.freebsd.org>
	<20050929130338.GC1715@garage.freebsd.pl>
Cc: Peter Edwards <peadar@freebsd.org>, cvs-src@freebsd.org,
	src-committers@freebsd.org, cvs-all@freebsd.org
Subject: Re: cvs commit: src/sys/kern vfs_bio.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: Peter Edwards <peadar.edwards@gmail.com>
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 29 Sep 2005 13:49:10 -0000

On 9/29/05, Pawel Jakub Dawidek <pjd@freebsd.org> wrote:
> On Thu, Sep 29, 2005 at 10:37:20AM +0000, Peter Edwards wrote:
> +> peadar      2005-09-29 10:37:20 UTC
> +>
> +>   FreeBSD src repository
> +>
> +>   Modified files:
> +>     sys/kern             vfs_bio.c
> +>   Log:
> +>   Close a race in biodone(), whereby the bio_done field of the passed
> +>   bio may have been freed and reassigned by the wakeup before being
> +>   tested after releasing the bdonelock.
> +>
> +>   There's a non-zero chance this is the cause of a few of the crashes
> +>   knocking around with biodone() sitting in the stack backtrace.
>
> Should this fix the panic on boot in vmware?
>

That one falls under the "non-zero chance" mentioned above :-) The
problem was very intermittent for me, and wanting the laptop not to
fall over seemed to be a prerequisite to reproducing the panic, so I
can't positively say it's fixed the problem yet.

If you have a reliable way of reproducing the panic, can you try out
the patch and let me know?