From nobody Fri Sep 16 15:53:59 2022 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4MTdsg68Txz4cKr2; Fri, 16 Sep 2022 15:53:59 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4MTdsg5TdBz3htv; Fri, 16 Sep 2022 15:53:59 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1663343639; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=FsNl0HojR2lfDiJV929o3FfIGRSbrvo1nylCrbSGWTA=; b=udRFEU5MOqC0KsDWWgMNsfMq/TCVNkb/0EMi2i17EgD83fM7VHrqoZDG3/PCgA+A46CVpf 56OSCnl4J+4J+HRD2gfdYiXS1UeX5d18x41NBGPFwZ8nj2Tlc7LPvTycmiZ4nFIwb2/GjP +wEZeCmccbZ4P8s8lgdMHPksfaii0XsQNmAIDZioNShMGLQR4kU71wjsrz/Xl4r2EdsKkj dOvtFNPg+H1/7tlh9SQQW0XbgX+KzfzORtk0gHzQl/tDUZbSalveuRIrmYGlLsxIhgtAMz fegdbx12QPOEtWvPpB3+Zazzj5fsfkmw95Bjd+vNQYmCQYEyaEqpqfcxvNimBQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4MTdsg4SRFzPwM; Fri, 16 Sep 2022 15:53:59 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 28GFrxWT086507; Fri, 16 Sep 2022 15:53:59 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 28GFrxHG086506; Fri, 16 Sep 2022 15:53:59 GMT (envelope-from git) Date: Fri, 16 Sep 2022 15:53:59 GMT Message-Id: <202209161553.28GFrxHG086506@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Warner Losh Subject: git: e895ab3fbdc1 - main - stand: Remove dead store to bi_kernelname List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: imp X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: e895ab3fbdc10fbf944289165c25357cb3f279fe Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1663343639; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=FsNl0HojR2lfDiJV929o3FfIGRSbrvo1nylCrbSGWTA=; b=aLNgBbE20jLb1nZXMj2jxbF8hv+KcsFXK7AvGEujbpRLpgeaV6LKaGFv2MgsNGbHan8roH QC3K1z1IX8vtS0ypDwj2BgFIvahwrSClgb/E31QyCpAc/CM3n1qI7uOcjl3GuT79KIwA7A /9q/cWb2lnT3T/E5cKy+f3gWbmjC3auBXoTcro4b2Ju3gK+DgKGk27NHSovEjk7cIej1Aq n4qZIaFzp1yEs7Pqi15jMYxinlgle8Xksnb9tV/qV2+0EtXZ/EjGNf6xRNpzWEN3E/CsqQ djx5ilBsN2EU/cTuJSXFGz5tF3ygksd3W/GAwb7FtZMqJB1XdtuyEkyzt8rQEA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1663343639; a=rsa-sha256; cv=none; b=PGJpg3tuBUn2i6bTTZzv7D5JBm4bQ2tPSliYsZh5EFI1pTP4z64e0EIdD2esy46GLkgiHj /jmRgFd7amZpkk/qzsg9ZL3Mbz6646IjzR1Ce/d8x+CO2K+0onctlprdIIV9hBXCdV4k/v cz8lj2pvB3FkGMNomr2tGwd0UkmoRRc4C7iaOkZDHRcRugRM3hTsQUMhfhLkyl5iNB7jwI tMwtJDWCuMTpORSALhwIaYqwVAhPyV0plSOHOR2Hc9KtJd0bNYpIY2OXQQoTD5YXs1HGxu bkbeNh9xtL3CjsBXthFeY/ZdT4tNCNER2TCFz2/Uih6TuAbOATtuQYKgXhGZKg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by imp: URL: https://cgit.FreeBSD.org/src/commit/?id=e895ab3fbdc10fbf944289165c25357cb3f279fe commit e895ab3fbdc10fbf944289165c25357cb3f279fe Author: Warner Losh AuthorDate: 2022-09-16 15:09:02 +0000 Commit: Warner Losh CommitDate: 2022-09-16 15:18:56 +0000 stand: Remove dead store to bi_kernelname We set this value twice: once to 0 and once to the VA that has the name of the kernel. The first store is redundant. In addition, these two stores of 0 are also redundant. Since we never set them, they will always be zero, even if we're called multiple times. This saves 21 bytes on BIOS loader. Sponsored by: Netflix Differential Revision: https://reviews.freebsd.org/D36541 --- stand/i386/libi386/bootinfo32.c | 3 --- stand/userboot/userboot/bootinfo32.c | 3 --- 2 files changed, 6 deletions(-) diff --git a/stand/i386/libi386/bootinfo32.c b/stand/i386/libi386/bootinfo32.c index 9ca6a70d674e..68aae9b67ba9 100644 --- a/stand/i386/libi386/bootinfo32.c +++ b/stand/i386/libi386/bootinfo32.c @@ -173,9 +173,6 @@ bi_load32(char *args, int *howtop, int *bootdevp, vm_offset_t *bip, vm_offset_t kernelname = getenv("kernelname"); i386_getdev(NULL, kernelname, &kernelpath); bi.bi_version = BOOTINFO_VERSION; - bi.bi_kernelname = 0; /* XXX char * -> kernel name */ - bi.bi_nfs_diskless = 0; /* struct nfs_diskless * */ - bi.bi_n_bios_used = 0; /* XXX would have to hook biosdisk driver for these */ for (i = 0; i < N_BIOS_GEOM; i++) bi.bi_bios_geom[i] = bd_getbigeom(i); bi.bi_size = sizeof(bi); diff --git a/stand/userboot/userboot/bootinfo32.c b/stand/userboot/userboot/bootinfo32.c index 08dde13baa30..d496384fbcb5 100644 --- a/stand/userboot/userboot/bootinfo32.c +++ b/stand/userboot/userboot/bootinfo32.c @@ -152,9 +152,6 @@ bi_load32(char *args, int *howtop, int *bootdevp, vm_offset_t *bip, vm_offset_t kernelname = getenv("kernelname"); userboot_getdev(NULL, kernelname, &kernelpath); bi.bi_version = BOOTINFO_VERSION; - bi.bi_kernelname = 0; /* XXX char * -> kernel name */ - bi.bi_nfs_diskless = 0; /* struct nfs_diskless * */ - bi.bi_n_bios_used = 0; /* XXX would have to hook biosdisk driver for these */ #if 0 for (i = 0; i < N_BIOS_GEOM; i++) bi.bi_bios_geom[i] = bd_getbigeom(i);