From owner-cvs-src@FreeBSD.ORG Fri May 6 06:20:18 2005 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6755B16A4CE for ; Fri, 6 May 2005 06:20:18 +0000 (GMT) Received: from mail25.sea5.speakeasy.net (mail25.sea5.speakeasy.net [69.17.117.27]) by mx1.FreeBSD.org (Postfix) with ESMTP id B0C7743D9C for ; Fri, 6 May 2005 06:20:15 +0000 (GMT) (envelope-from jmg@hydrogen.funkthat.com) Received: (qmail 15311 invoked from network); 6 May 2005 06:20:15 -0000 Received: from gate.funkthat.com (HELO hydrogen.funkthat.com) ([69.17.45.168]) (envelope-sender ) by mail25.sea5.speakeasy.net (qmail-ldap-1.03) with SMTP for ; 6 May 2005 06:20:15 -0000 Received: from hydrogen.funkthat.com (efezkl@localhost.funkthat.com [127.0.0.1])j466KEmo040588; Thu, 5 May 2005 23:20:14 -0700 (PDT) (envelope-from jmg@hydrogen.funkthat.com) Received: (from jmg@localhost) by hydrogen.funkthat.com (8.12.10/8.12.10/Submit) id j466KDRg040587; Thu, 5 May 2005 23:20:13 -0700 (PDT) Date: Thu, 5 May 2005 23:20:13 -0700 From: John-Mark Gurney To: "M. Warner Losh" Message-ID: <20050506062013.GD2670@funkthat.com> References: <200505060248.j462mL0k009905@repoman.freebsd.org> <20050506032202.GC2670@funkthat.com> <20050505.232214.96921001.imp@bsdimp.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050505.232214.96921001.imp@bsdimp.com> User-Agent: Mutt/1.4.1i X-Operating-System: FreeBSD 4.2-RELEASE i386 X-PGP-Fingerprint: B7 EC EF F8 AE ED A7 31 96 7A 22 B3 D8 56 36 F4 X-Files: The truth is out there X-URL: http://resnet.uoregon.edu/~gurney_j/ X-Resume: http://resnet.uoregon.edu/~gurney_j/resume.html cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: cvs-all@freebsd.org cc: cperciva@freebsd.org Subject: Re: cvs commit: src/sys/kern subr_bus.c subr_rman.c vfs_subr.c src/sys/net if_mib.c src/sys/netinet ip_divert.c raw_ip.c udp_usrreq.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: John-Mark Gurney List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 May 2005 06:20:18 -0000 Warner Losh wrote this message on Thu, May 05, 2005 at 23:22 -0600: > In message: <20050506032202.GC2670@funkthat.com> > John-Mark Gurney writes: > : Colin Percival wrote this message on Fri, May 06, 2005 at 02:48 +0000: > : > cperciva 2005-05-06 02:48:21 UTC > : > > : > FreeBSD src repository > : > > : > Modified files: > : > sys/kern subr_bus.c subr_rman.c vfs_subr.c > : > sys/net if_mib.c > : > sys/netinet ip_divert.c raw_ip.c udp_usrreq.c > : > Log: > : > If we are going to > : > 1. Copy a NULL-terminated string into a fixed-length buffer, and > : > 2. copyout that buffer to userland, > : > we really ought to > : > 0. Zero the entire buffer > : > first. > : > > : > Security: FreeBSD-SA-05:08.kmem > : > : /me notes this is a good reason to use strncpy instead of strlcpy. > > Don't you mean the opposite? Nope, from strncpy(3): The strncpy() copies not more than len characters into dst, appending `\0' characters if src is less than len characters long, This is a little bit terse, but strncpy NUL pads the remaining buffer, unlike strlcpy which leaves any unused bytes untouched... And yes, our libkern version of strncpy does do this: /* NUL pad the remaining n-1 bytes */ while (--n != 0) *d++ = 0; -- John-Mark Gurney Voice: +1 415 225 5579 "All that I will do, has been done, All that I have, has not."