From owner-freebsd-ports-bugs@FreeBSD.ORG Tue Dec 18 00:30:00 2012 Return-Path: Delivered-To: freebsd-ports-bugs@smarthost.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id EA309EF9 for ; Tue, 18 Dec 2012 00:30:00 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by mx1.freebsd.org (Postfix) with ESMTP id BDCF88FC15 for ; Tue, 18 Dec 2012 00:30:00 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id qBI0U0vc072223 for ; Tue, 18 Dec 2012 00:30:00 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id qBI0U0KA072219; Tue, 18 Dec 2012 00:30:00 GMT (envelope-from gnats) Resent-Date: Tue, 18 Dec 2012 00:30:00 GMT Resent-Message-Id: <201212180030.qBI0U0KA072219@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Renato Ornelas Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id BB026B7A for ; Tue, 18 Dec 2012 00:21:41 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22]) by mx1.freebsd.org (Postfix) with ESMTP id A18718FC0C for ; Tue, 18 Dec 2012 00:21:41 +0000 (UTC) Received: from red.freebsd.org (localhost [127.0.0.1]) by red.freebsd.org (8.14.5/8.14.5) with ESMTP id qBI0LfdE088094 for ; Tue, 18 Dec 2012 00:21:41 GMT (envelope-from nobody@red.freebsd.org) Received: (from nobody@localhost) by red.freebsd.org (8.14.5/8.14.5/Submit) id qBI0LepK088087; Tue, 18 Dec 2012 00:21:41 GMT (envelope-from nobody) Message-Id: <201212180021.qBI0LepK088087@red.freebsd.org> Date: Tue, 18 Dec 2012 00:21:41 GMT From: Renato Ornelas To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Subject: ports/174533: net/openbgpd doesn't reload after config error (previous reload still running) X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Dec 2012 00:30:01 -0000 >Number: 174533 >Category: ports >Synopsis: net/openbgpd doesn't reload after config error (previous reload still running) >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Tue Dec 18 00:30:00 UTC 2012 >Closed-Date: >Last-Modified: >Originator: Renato Ornelas >Release: 7.3-RELEASE-p2 >Organization: Open X >Environment: FreeBSD bgp1.openx.com.br 7.3-RELEASE-p2 FreeBSD 7.3-RELEASE-p2 #0: Mon Jul 12 19:04:04 UTC 2010 root@i386-builder.daemonology.net:/usr/obj/usr/src/sys/GENERIC i386 >Description: After upgrading to openbgp-5.2.20121014, bgpctl cant reload a config after the config file has any error. Dec 17 18:22:51 bgp2 bgpd[37607]: /etc/bgpd/clientes.conf:855: syntax error Dec 17 18:22:51 bgp2 bgpd[37607]: /etc/bgpd/clientes.conf:858: start prefixlen is bigger than end Dec 17 18:22:51 bgp2 bgpd[37607]: config file /usr/local/etc/bgpd.conf has errors, not reloading After you correct the error, bgpctl reload starts giving the following error: bgp2# bgpctl re reload request sent. previous reload still running You need to restart openbgpd to correct the error >How-To-Repeat: Put any invalid option on the config file, issue a bgpctl reload, correct the file and give another reload to bgpctl >Fix: --- src/usr.sbin/bgpd/bgpd.c 2012/09/18 10:45:51 1.169 +++ src/usr.sbin/bgpd/bgpd.c 2012/11/02 19:02:45 1.170 @@ -1,4 +1,4 @@ -/* $OpenBSD: bgpd.c,v 1.169 2012/09/18 09:45:51 claudio Exp $ */ +/* $OpenBSD: bgpd.c,v 1.170 2012/11/02 18:02:45 florian Exp $ */ /* * Copyright (c) 2003, 2004 Henning Brauer @@ -436,6 +436,7 @@ reconfigure(char *conffile, struct bgpd_config *conf, &rdom_l)) { log_warnx("config file %s has errors, not reloading", conffile); + reconfpending = 0; return (1); } >Release-Note: >Audit-Trail: >Unformatted: