From owner-freebsd-current@freebsd.org Sat Oct 22 16:23:15 2016 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 66B36C1CBB7 for ; Sat, 22 Oct 2016 16:23:15 +0000 (UTC) (envelope-from baptiste.daroussin@gmail.com) Received: from mail-wm0-x243.google.com (mail-wm0-x243.google.com [IPv6:2a00:1450:400c:c09::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id F279BBFC; Sat, 22 Oct 2016 16:23:14 +0000 (UTC) (envelope-from baptiste.daroussin@gmail.com) Received: by mail-wm0-x243.google.com with SMTP id d128so3218711wmf.0; Sat, 22 Oct 2016 09:23:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=IynkmVd1Zyll0SpYzs0Y5bdmWX+bxQRJXBtIVnOc/mA=; b=XgkJIdQqgShrrhRf69xtzCW55vmZsNM4oHMpvyx90S0MEuktqvf66hKd+Z5RK4Eo5p 3uVoLChP5k7INcwjXNF8ik9UQ1EayZhT+DdORsgwbz1x25WPcfcnDG/RGG6Di1nVsdzY Qac6o+dB54VNeD6HYAL11Zq+6/e3lLyd5EheK1MVKDuU8UJiSYr1GKqns9F3MHiH+DaA JQ2DVdyr+L/Fl52B8bb/WsMlr2i8Y9MM784BOpA+1wzuQDT9NbDhVBMIIqlikhfWqG5n jA5qMAca8IjOD0K9cJg/j2Iwi9Szt8cFbjkOAQkj9R4HGtBQXjgtYkvojC1y1b+imDX7 a1zA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=IynkmVd1Zyll0SpYzs0Y5bdmWX+bxQRJXBtIVnOc/mA=; b=AKEXuvsWp87EjAVZPRP9k2jnjLctihOHjgOOrqeiZESrWshqRzTSHFbPY0S5CgCoXh vYbKrMJyiAtzGbmhhGXzxqRIc01vzS5s0wuUyrhrbLdVOxK4iLagxCYuvNPV3rhTD4RJ 4IxnVt1H0YqDfASVgDS2qYhbtawC3bYH1Rzm+/greEVfGtk6k1yF8s282rtajQEnHkbZ UFhtQnn+CzRtEsCCvw4NYi+CxMEKF38DvmMA5Ab9E4x9gMBx3dC94H2dvr0HWTBaBDLm G706AGtRbQ4oDCWjLvNWVTB7UduMEnyknrnqmha4tL951XkCN0UvLImAeedCZIRfUnDf Qr9w== X-Gm-Message-State: AA6/9RmGQlBmmRQAhfNyBfjt8Lck4rdLIFE3L6TToB0VdfSMlmsGwJhjIdIE7UhOpBDvIQ== X-Received: by 10.28.6.198 with SMTP id 189mr8037249wmg.16.1477153393297; Sat, 22 Oct 2016 09:23:13 -0700 (PDT) Received: from ivaldir.etoilebsd.net ([2001:41d0:8:db4c::1]) by smtp.gmail.com with ESMTPSA id c4sm4548944wmh.4.2016.10.22.09.23.12 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 22 Oct 2016 09:23:12 -0700 (PDT) Sender: Baptiste Daroussin Date: Sat, 22 Oct 2016 18:23:11 +0200 From: Baptiste Daroussin To: Guy Yur Cc: freebsd-current , emaste@freebsd.org Subject: Re: installworld fails on missing tzsetup when WITHOUT_DIALOG is set Message-ID: <20161022162311.d7ewekapcuiubuxh@ivaldir.etoilebsd.net> References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="so7woetn35mr5jwj" Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20161014 (1.7.1) X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 22 Oct 2016 16:23:15 -0000 --so7woetn35mr5jwj Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Oct 22, 2016 at 06:51:28PM +0300, Guy Yur wrote: > Hi, >=20 > installworld fails on missing tzsetup when src.conf has WITHOUT_DIALOG=3D > and delete-old was previously run to remove tzsetup from the system. >=20 > mkdir -p /tmp/install.8gNIwAFV > progs=3D$(for prog in [ awk cap_mkdb cat chflags chmod chown cmp cp > date echo egrep find grep id install ln make mkdir mtree mv pwd_mkdb > rm sed services_mkdb sh strip sysctl test true uname wc zic tzsetup > makewhatis; do if progpath=3D`which $prog`; then echo $progpath; else > echo "Required tool $prog not found in PATH." >&2; exit 1; fi; > done); libs=3D$(ldd -f "%o %p\n" -f "%o %p\n" $progs 2>/dev/null | sort > -u | while read line; do set -- $line; if [ "$2 $3" !=3D "not found" > ]; then echo $2; else echo "Required library $1 not found." >&2; > exit 1; fi; done); cp $libs $progs /tmp/install.8gNIwAFV > Required tool tzsetup not found in PATH. > *** Error code 1 >=20 > tzsetup is used in share/zoneinfo/Makefile when ${DESTDIR}/var/db/zoneinfo > exists and some other conditions. >=20 > In my case, I don't have /var/db/zoneinfo since I manually created a syml= ink > from /usr/share/zoneinfo/... to /etc/localtime instead of using tzsetup. >=20 > A possible fix is to add a WITHOUT_TZSETUP knob and not use > tzsetup when the knob is enabled. >=20 > https://github.com/guyyur/freebsd-src_patches/blob/master/without_tzsetup= _knob.patch > (patch doesn't include regenerating src.conf.5) >=20 > Thanks, > Guy > _______________________________________________ My proposal is a bit different: build tzsetup without dialog support :) https://reviews.freebsd.org/D8325 Best regards, Bapt --so7woetn35mr5jwj Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJYC5JmAAoJEGOJi9zxtz5a0KYQAKC5R8ArPsTxBf9270sJEi13 38FlYzrQTkSIR88tthpV25qf2ans11KYO3XLfDKd/eZ0cN13ND2SiOt5AQeh4DVk fWV0UXJfkknKbOU777sLP3LIIFatYA1z7pMHXVN17IVhM+2ASkmLV9kh8Qr0neZ9 WEYzvZxWYbMLPp0mxk9pwWP7Zx0jBG3apCF0RmBfnCkRB48aAkBxnQinGJ1QLpjM 8n9eaBy5PRK5Bu/kEwbzODro+RU2DugcOuvGXiECzqQSWff52gXTj0Cx7E+xie4j c7cO6tOIO1KOmiPEKibzGacoX40RTvsR1ZYSqWAvKClqVzHMPp3+8Ymdl9/UDDcM s9i2/We90Z2WiIc+ixE0qN0e7jDOYc2AOSEZsWep0/CnzDyXL2CgX87JC8lJVwpn hR/VDZqbQlfHc0l2/hDsaLAqFcKNlbbmag4t1eRg24mqVW0u2m7p/owqesThy9oF Wreu9ABD8KRlNcmJdzoVYbRD2H760BoJG5nWi8GPTqcD9fd5S4o0icIB8BkPLQcP wktcGhLJ90hO7hRI3bO6EjJVcyujjJOkz751b/5gBugeH0rklTK37EONU2b++6U/ KpOw/B8O9a8MjmTwvwv69aLcn/fZxQ8aNYp8TQWSdpWFJNoy4DF35MJEBJLl75g3 NuKbsra1PV2SHL1icHnE =9Uh3 -----END PGP SIGNATURE----- --so7woetn35mr5jwj--