From owner-svn-src-stable-7@FreeBSD.ORG Wed Nov 30 22:53:48 2011 Return-Path: Delivered-To: svn-src-stable-7@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1FDCE106564A; Wed, 30 Nov 2011 22:53:48 +0000 (UTC) (envelope-from rmacklem@uoguelph.ca) Received: from esa-jnhn.mail.uoguelph.ca (esa-jnhn.mail.uoguelph.ca [131.104.91.44]) by mx1.freebsd.org (Postfix) with ESMTP id CF0218FC15; Wed, 30 Nov 2011 22:53:46 +0000 (UTC) X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Ap4EAPmy1k6DaFvO/2dsb2JhbABEhQOnFIFyAQEFI1YbDgoCAg0ZAlkGE68BkU+BMII9hh2BFgSIKIwvki4 X-IronPort-AV: E=Sophos;i="4.71,273,1320642000"; d="scan'208";a="147739852" Received: from erie.cs.uoguelph.ca (HELO zcs3.mail.uoguelph.ca) ([131.104.91.206]) by esa-jnhn-pri.mail.uoguelph.ca with ESMTP; 30 Nov 2011 17:52:21 -0500 Received: from zcs3.mail.uoguelph.ca (localhost.localdomain [127.0.0.1]) by zcs3.mail.uoguelph.ca (Postfix) with ESMTP id C7C15B3F10; Wed, 30 Nov 2011 17:52:21 -0500 (EST) Date: Wed, 30 Nov 2011 17:52:21 -0500 (EST) From: Rick Macklem To: Mark Saad Message-ID: <1769030615.700252.1322693541806.JavaMail.root@erie.cs.uoguelph.ca> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [172.17.91.201] X-Mailer: Zimbra 6.0.10_GA_2692 (ZimbraWebClient - FF3.0 (Win)/6.0.10_GA_2692) Cc: src-committers@freebsd.org, svn-src-stable@freebsd.org, svn-src-all@freebsd.org, Alfred Perlstein , svn-src-stable-7@freebsd.org, Rick Macklem Subject: Re: svn commit: r227549 - stable/7/sys/nfsclient X-BeenThere: svn-src-stable-7@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for only the 7-stable src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Nov 2011 22:53:48 -0000 Mark Saad wrote: > On Thu, Nov 17, 2011 at 1:36 PM, Alfred Perlstein > wrote: > > * Rick Macklem [111116 21:16] wrote: > >> Alfred Perlstein wrote: > >> > Rick, I have a question, what will happen if the > >> > nfs_freesillyrename() > >> > call happens when the mount is down? Will it block the > >> > taskqueue_thread? > >> > > >> > If so, it might make more sense to make a taskqueue per mount > >> > point. > >> > > >> > If not, excuse me. :-) > >> > > >> Well, all nfs_freesillyrename() does is a vrele() on the parent > >> directory when the file node's use count has gone to 0. > >> I can't think why that would do any RPC, so I don't see a problem? > >> If you do see a problem with vrele() on the directory, please let > >> me > >> know. > >> > >> The problem this fixes is a LOR that would occur when the vrele() > >> on > >> the directory was done by the thread doing VOP_INACTIVE(), since it > >> already has the file vnode lock and the vrele() was locking the > >> parent > >> directory. This could cause a fairly rare deadlock. > > > > Yes, I understand the VFS deadlock. > > > > I see, I didn't realize the call was against the directory, > > thank you for explaining. > > > > -Alfred > Rick > Any chance this will make it back into 7.3-RELEASE and 7.4-RELEASE ? > I'm relatively new to FreeBSD, but I've never heard of an MFC to a Release branch. (As far as I know, if it ever happens, it's for a serious errata or security issue.) Unless I'm incorrect (someone please correct me if I'm wrong), the answer would be no, rick. > > -- > mark saad | nonesuch@longcount.org