From owner-cvs-all Tue Nov 27 10:54: 3 2001 Delivered-To: cvs-all@freebsd.org Received: from whale.sunbay.crimea.ua (whale.sunbay.crimea.ua [212.110.138.65]) by hub.freebsd.org (Postfix) with ESMTP id B625E37B419; Tue, 27 Nov 2001 10:53:44 -0800 (PST) Received: (from ru@localhost) by whale.sunbay.crimea.ua (8.11.6/8.11.2) id fARIreS27557; Tue, 27 Nov 2001 20:53:40 +0200 (EET) (envelope-from ru) Date: Tue, 27 Nov 2001 20:53:40 +0200 From: Ruslan Ermilov To: "David O'Brien" Cc: Dag-Erling Smorgrav , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/contrib/libpam/libpam pam_item.c Message-ID: <20011127205340.D25113@sunbay.com> References: <200111271535.fARFZiN39835@freefall.freebsd.org> <20011127174709.J67032@sunbay.com> <20011127092004.A68382@dragon.nuxi.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20011127092004.A68382@dragon.nuxi.com> User-Agent: Mutt/1.3.23i Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Tue, Nov 27, 2001 at 09:20:04AM -0800, David O'Brien wrote: > On Tue, Nov 27, 2001 at 05:47:09PM +0200, Ruslan Ermilov wrote: > > On Tue, Nov 27, 2001 at 07:35:44AM -0800, Dag-Erling Smorgrav wrote: > > > des 2001/11/27 07:35:44 PST > > > > > > Modified files: > > > contrib/libpam/libpam pam_item.c > > > Log: > > > It's idiotic to return PAM_PERM_DENIED when the item argument is NULL; > > > PAM_BUF_ERR is much closer to the truth. > > > > > > Revision Changes Path > > > 1.2 +102 -81 src/contrib/libpam/libpam/pam_item.c > > > > > DES! > > > > Please keep this out from commitlogs. > > When did we get so "Politically Correct"? Geez people is it now desired > we turn into drones? > I sense frustration in DES's message and it was probably a goose-chase > debugging session that led him to the problem. Thus the furstraition was > founded. > > I hope their ears are burning and it shames them into fixing it. :-) > I take it as if you don't object if someone calls your code "idiotic", David? :-) Cheers, -- Ruslan Ermilov Oracle Developer/DBA, ru@sunbay.com Sunbay Software AG, ru@FreeBSD.org FreeBSD committer, +380.652.512.251 Simferopol, Ukraine http://www.FreeBSD.org The Power To Serve http://www.oracle.com Enabling The Information Age To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message