From owner-cvs-src@FreeBSD.ORG Thu Jul 31 17:42:29 2008 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5765F106564A; Thu, 31 Jul 2008 17:42:29 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (bigknife-pt.tunnel.tserv9.chi1.ipv6.he.net [IPv6:2001:470:1f10:75::2]) by mx1.freebsd.org (Postfix) with ESMTP id CD37A8FC12; Thu, 31 Jul 2008 17:42:28 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from localhost.corp.yahoo.com (john@localhost [IPv6:::1]) (authenticated bits=0) by server.baldwin.cx (8.14.2/8.14.2) with ESMTP id m6VHgMXi037888; Thu, 31 Jul 2008 13:42:22 -0400 (EDT) (envelope-from jhb@freebsd.org) From: John Baldwin To: Kostik Belousov Date: Thu, 31 Jul 2008 11:20:39 -0400 User-Agent: KMail/1.9.7 References: <200807302112.m6ULCThe046074@repoman.freebsd.org> <20080731090651.GX97161@deviant.kiev.zoral.com.ua> In-Reply-To: <20080731090651.GX97161@deviant.kiev.zoral.com.ua> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200807311120.40094.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [IPv6:::1]); Thu, 31 Jul 2008 13:42:22 -0400 (EDT) X-Virus-Scanned: ClamAV 0.93.1/7899/Thu Jul 31 11:40:41 2008 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-2.5 required=4.2 tests=AWL,BAYES_00,NO_RELAYS autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/vm swap_pager.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 31 Jul 2008 17:42:29 -0000 On Thursday 31 July 2008 05:06:51 am Kostik Belousov wrote: > On Wed, Jul 30, 2008 at 09:12:15PM +0000, John Baldwin wrote: > > jhb 2008-07-30 21:12:15 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/vm swap_pager.c > > Log: > > SVN rev 181019 on 2008-07-30 21:12:15Z by jhb > > > > If the kernel has run out of metadata for swap, then explicitly panic() > > instead of emitting a warning before deadlocking. > > > > MFC after: 1 month > > > > Revision Changes Path > > 1.303 +1 -1 src/sys/vm/swap_pager.c > > Hmm, would it make sense to attempt to sync the filesystems ? We > panic due to resource exhaustion as opposed to some data consistency > violation. Sure, sync might deadlock too, because we may be in the low > memory condition. There is already a 'sync on panic' option for the brave. :) What would really be a better fix is if this condition could be treated the same as running out of swap space (i.e. go kill a process and keep running). I would have done that in the first place instead of adding the printf if it was easy. :) -- John Baldwin