From owner-svn-src-head@FreeBSD.ORG Wed Nov 14 16:27:37 2012 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id D6E7333B for ; Wed, 14 Nov 2012 16:27:37 +0000 (UTC) (envelope-from lists@eitanadler.com) Received: from mail-la0-f54.google.com (mail-la0-f54.google.com [209.85.215.54]) by mx1.freebsd.org (Postfix) with ESMTP id 3BC748FC13 for ; Wed, 14 Nov 2012 16:27:36 +0000 (UTC) Received: by mail-la0-f54.google.com with SMTP id j13so625434lah.13 for ; Wed, 14 Nov 2012 08:27:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eitanadler.com; s=0xdeadbeef; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type; bh=ACkUCZHIXUa8x9PYVOnQq9TgyiHpBwBhRVXs75O3jPw=; b=nZ27AGASWclH9fIQMc1hKIoupQlK7evL7bpYrpG/ARKxKU3K84zJdNUAoopuRpZJ4f fXcxcY7AJHrzAW55xlxJrPFakEy3btISNgQWQD8rWyOMGDTeb1coooVZt0cc4ry8I82y jgJy1SQ4BmLXAhZHFVidAI59ubr8gAKgjwEBc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type :x-gm-message-state; bh=ACkUCZHIXUa8x9PYVOnQq9TgyiHpBwBhRVXs75O3jPw=; b=SzxVAhCzRGdl5O9MKuvmgWs/oZjN9yvCsZHT1CgcegCzzpHFe14NAyLndEfZYP56HA jPTWp0nr6355BPZbU6Xw8C+CADXEDUB9k9za888A+zvDSLOiR4DY9TptzyCLhnCOiORD q/Mom7vKrcRDVM3DqxGNx5fIg0nf51qhCIGDPTL8/Xoo6iwAg7TGsyCT2/JXYsS0SixZ mhAKVVpcU/1b7fdLdEqxIHH6qJD9nu8mOblbRPqwFyqwyIBF4DfjHnOk/NpqWF2kaIc2 Baa19UN4w//g0GYxZFnOJLLE9jyP/fIGsKUPMX5bgWPuNehMZL5MklBK4uqF88IgqtLT IrEg== Received: by 10.112.13.140 with SMTP id h12mr11125725lbc.12.1352910456084; Wed, 14 Nov 2012 08:27:36 -0800 (PST) MIME-Version: 1.0 Sender: lists@eitanadler.com Received: by 10.112.25.166 with HTTP; Wed, 14 Nov 2012 08:27:05 -0800 (PST) In-Reply-To: References: <201211140805.qAE85MHU031099@svn.freebsd.org> <50A364AE.6060205@freebsd.org> <20121114093236.GJ28213@FreeBSD.org> From: Eitan Adler Date: Wed, 14 Nov 2012 11:27:05 -0500 X-Google-Sender-Auth: JH6xCm5Qg8MUFjG9FOJQip2_dOk Message-ID: Subject: Re: svn commit: r243019 - head/sbin/route To: Ben Kaduk Content-Type: text/plain; charset=UTF-8 X-Gm-Message-State: ALoCoQm+M8oFmL0jDT6zdPirQjQEFAKAdtVaikREWaN7e5Fw758KtLAEOoZ/+IL/l8QTrfgoRMwm Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, Gleb Smirnoff , Andre Oppermann , src-committers@freebsd.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Nov 2012 16:27:38 -0000 On 14 November 2012 11:12, Ben Kaduk wrote: > On Wed, Nov 14, 2012 at 4:32 AM, Gleb Smirnoff wrote: >> A> Can the IN_CLASS[A-C]_NET... definitions go away as well? >> >> They are defines that don't generate any code. >> >> Also, on this mailing list I've promised once not to remove them :) > > I'm glad you remember :) Perhaps a comment indicating they shouldn't be removed should be added? > Andre, they are used (for better or for worse) in a multi-site > database synchronization protocol that currently works portably across > operating systems. Removing them would change the semantics of that > protocol in a subtle way that might introduce breakage. Which one? -- Eitan Adler Source, Ports, Doc committer Bugmeister, Ports Security teams