From owner-freebsd-pf@FreeBSD.ORG  Wed May 30 15:26:03 2007
Return-Path: <owner-freebsd-pf@FreeBSD.ORG>
X-Original-To: freebsd-pf@freebsd.org
Delivered-To: freebsd-pf@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 93D2816A469
	for <freebsd-pf@freebsd.org>; Wed, 30 May 2007 15:26:03 +0000 (UTC)
	(envelope-from ermal.luci@gmail.com)
Received: from wx-out-0506.google.com (wx-out-0506.google.com [66.249.82.227])
	by mx1.freebsd.org (Postfix) with ESMTP id 497A813C468
	for <freebsd-pf@freebsd.org>; Wed, 30 May 2007 15:26:03 +0000 (UTC)
	(envelope-from ermal.luci@gmail.com)
Received: by wx-out-0506.google.com with SMTP id h28so1569409wxd
	for <freebsd-pf@freebsd.org>; Wed, 30 May 2007 08:26:02 -0700 (PDT)
DKIM-Signature: a=rsa-sha1; c=relaxed/relaxed; d=gmail.com; s=beta;
	h=domainkey-signature:received:received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references;
	b=Tfx/Wm63FyB3M0Yen82GbJOyUVeYO4oKmmOSKERH3JRnx3857ktbquoMYTx1yFGXxPwHUZuVBUBZp0rt+nX6gSA9VM00pEgYRpHnzYA3hO+7cYgYEmNgMnA96Xh60G+gim2qGoBucr7LmOobdlEQADc16OixcNwVP7lk/qPi1GI=
DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta;
	h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references;
	b=BsC7ZHzxw6A8BVEC6hllROpi79/hE/i+Lh45uFmiJdg+B2LUVjjR/27t/A9PsZ0Q3/x9z3bDIDexfX4z41BW+v7huwLfrA9QS1MFBSMfPz+9zttcg74mpfVcbLgrNSTl7ngzMDSvyXxADTyWqohrBbIaNbaT1Gcabzeid8+WI04=
Received: by 10.70.52.1 with SMTP id z1mr12284925wxz.1180538762184;
	Wed, 30 May 2007 08:26:02 -0700 (PDT)
Received: by 10.70.73.1 with HTTP; Wed, 30 May 2007 08:26:02 -0700 (PDT)
Message-ID: <9a542da30705300826g30e281bal6a68d5e17902fc21@mail.gmail.com>
Date: Wed, 30 May 2007 17:26:02 +0200
From: "=?ISO-8859-1?Q?Ermal_Lu=E7i?=" <ermal.luci@gmail.com>
To: "Alexander Motin" <mav@freebsd.org>
In-Reply-To: <465D5D50.2020009@freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline
References: <1180481012.00748860.1180470003@10.7.7.3>
	<465D5D50.2020009@freebsd.org>
Cc: freebsd-net@freebsd.org, freebsd-pf@freebsd.org
Subject: Re: [PATCH] ng_pf and l7 filtering possibility with PF
X-BeenThere: freebsd-pf@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "Technical discussion and general questions about packet filter
	\(pf\)" <freebsd-pf.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-pf>,
	<mailto:freebsd-pf-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-pf>
List-Post: <mailto:freebsd-pf@freebsd.org>
List-Help: <mailto:freebsd-pf-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-pf>,
	<mailto:freebsd-pf-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 30 May 2007 15:26:03 -0000

Alexander,

the only reason i made them available only for debugging is cause of
int32_t types of those counter  and these could overflow easily on
busy environments.
For 64bit counters on 32bit archs you need atomic operations and i
don't know how much overhead it will be!?(correct me if i am wrong)


On 5/30/07, Alexander Motin <mav@freebsd.org> wrote:
> Hi.
>
> Ermal Lu=E7i wrote:
> > 4- The node has these messages:
> > #ifdef NG_PF_DEBUG
> >       NGM_PF_GET_STATS,       (number of packets in/out)
> >       NGM_PF_CLR_STATS,
> >       NGM_PF_GETCLR_STATS,
> > #endif
>
> What for comment them out? To save CPU on several addition operations?
> This stats could be used not only by developers but also by users and
> they may not be to rebuild kernel module to get that stats.
>
> --
> Alexander Motin
>