From owner-svn-src-head@FreeBSD.ORG Wed Jul 23 17:24:10 2014 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id A1848ED0; Wed, 23 Jul 2014 17:24:10 +0000 (UTC) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 3D26425BA; Wed, 23 Jul 2014 17:24:10 +0000 (UTC) Received: from tom.home (kib@localhost [127.0.0.1]) by kib.kiev.ua (8.14.9/8.14.9) with ESMTP id s6NHO1RW074088 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 23 Jul 2014 20:24:01 +0300 (EEST) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.9.2 kib.kiev.ua s6NHO1RW074088 Received: (from kostik@localhost) by tom.home (8.14.9/8.14.9/Submit) id s6NHO1MU074087; Wed, 23 Jul 2014 20:24:01 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Wed, 23 Jul 2014 20:24:01 +0300 From: Konstantin Belousov To: Pietro Cerutti Subject: Re: svn commit: r268494 - in head: lib/libsbuf sys/kern sys/sys Message-ID: <20140723172401.GK93733@kib.kiev.ua> References: <201407101308.s6AD8pbR080041@svn.freebsd.org> <20140721090718.GC51328@ptrcrt.ch> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="v3W/iicSVFo10VrQ" Content-Disposition: inline In-Reply-To: <20140721090718.GC51328@ptrcrt.ch> User-Agent: Mutt/1.5.23 (2014-03-12) X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.0 X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on tom.home Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, owner-src-committers@freebsd.org, Bryan Drewery X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Jul 2014 17:24:10 -0000 --v3W/iicSVFo10VrQ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jul 21, 2014 at 11:07:18AM +0200, Pietro Cerutti wrote: > On 2014-Jul-18, 18:47, Bryan Drewery wrote: > > On 2014-07-10 08:08, Pietro Cerutti wrote: > > > Author: gahr (ports committer) > > > Date: Thu Jul 10 13:08:51 2014 > > > New Revision: 268494 > > > URL: http://svnweb.freebsd.org/changeset/base/268494 > > >=20 > > > Log: > > > Implement Short/Small String Optimization in SBUF(9) and change=20 > > > lengths and > > > positions in the API from ssize_t and int to size_t. > > >=20 > > > CR: D388 > > > Approved by: des, bapt > > >=20 > > > Modified: > > > head/lib/libsbuf/Makefile > > > head/sys/kern/subr_sbuf.c > > > head/sys/sys/sbuf.h > > >=20 > > > Modified: head/lib/libsbuf/Makefile > > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > > > --- head/lib/libsbuf/Makefile Thu Jul 10 13:04:52 2014 (r268493) > > > +++ head/lib/libsbuf/Makefile Thu Jul 10 13:08:51 2014 (r268494) > > > @@ -4,7 +4,7 @@ LIB=3D sbuf > > > SHLIBDIR?=3D /lib > > > SRCS=3D subr_sbuf.c > > >=20 > > > -SHLIB_MAJOR =3D 6 > > > +SHLIB_MAJOR =3D 7 > > >=20 > > > SYMBOL_MAPS=3D ${.CURDIR}/Symbol.map > > > VERSION_DEF=3D ${.CURDIR}/Version.def > > >=20 > >=20 > > We have symbol versioning in libsbuf. Shouldn't need to bump the=20 > > version. Just need to add a compat function for everything. It would be= =20 > > a lot of work, but bumping for ssize_t->size_t seems gratuitous to me. >=20 > The bump was due mainly to the addition of the s_static_buf field to the > sbuf struct. So, how this invalidates the point of not breaking the ABI ? We do not bump .so version for versioned libraries. For all symbols (functions) which are affected by the change, the compat shims in the old namespace must be provided. --v3W/iicSVFo10VrQ Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBAgAGBQJTz++wAAoJEJDCuSvBvK1B/7IP/22/rvsIve8yhBQ/2nK6QCFI aziItiWb7HXrEQceyEGkfYzbY/ISSTQaZFvUatHwwTs+SRVr7HWsVgvmu27Jr6ne IVo+lhhNRUYWzwAmfrrdfTDQGAJMHymnp+zv0Zfi2vwZyBRcUk8BmkrKj/AQD3Mm goQBoVs6queTJ7jabD/t9kVl9xieg2p2VoD6/UZog03Kh/+oNyia9Xby9bHvEx2P 0nyeYSK8tru9nlXR5/oe7qcYN/WxneIvy8eSiN+o5cRNqP2l2okWQ1WziL00rlt+ t77DrWkJ2B1JWmpHRbRCjaPFzGxjehWC2qcvvEOZno8a6EiMsh/WOlay+GFRI+95 G/0ToY1ic/Xid5PDGvPj8k0PABPmaUyGGCs9xXjdWxedZv1tOzX5KjrH1vLZyPNw 7PSzzxDv2SYlqrcRz6lb3U7PWrhH5IufIa7mTXjT+J6IarQSCDsv75mVkhbwakob p5DCsWP75ck64PSPR/JzHVHvCJdL6u8/SPcmWB1gyvkQepIuJCUBVWQzo52y9NOS QOfNbHB69cAsQ2vXJLd0rpuHzA517colVPbYMnU2bfBw4HwsIhc2+XOy3AuxsCC3 fgX1d/jSP2TsXDrctlItShYKlN041droRSp1kcsl0/5aKru12VF2QLFfqs9Uo2Tn UQKGR0SFoIuCVwCrRyQi =edN7 -----END PGP SIGNATURE----- --v3W/iicSVFo10VrQ--