From nobody Tue Sep 23 09:50:49 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cWFby4y05z68PTj for ; Tue, 23 Sep 2025 09:51:10 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: from mail-ed1-x52e.google.com (mail-ed1-x52e.google.com [IPv6:2a00:1450:4864:20::52e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cWFbw65rjz45y5 for ; Tue, 23 Sep 2025 09:51:08 +0000 (UTC) (envelope-from mjguzik@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-ed1-x52e.google.com with SMTP id 4fb4d7f45d1cf-62fbfeb0870so5683408a12.2 for ; Tue, 23 Sep 2025 02:51:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1758621062; x=1759225862; darn=freebsd.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=V4giJWC/+uACYkH8OgTwb0xX9epOJOFH20WVIPjHeQA=; b=HJJ5zEoS+c/F8YvGrCnvrcZqP6+9p2zUp8xYGWTNWcEV4ISjae5NrPcyVEZ9P2bMdQ D4P6Uyr3+hzxsxpXLfIl5cYKxEZf3QQ07mjWn+FTm/o7XGN739hOeKsjNRQBJ0kFmM7D jnUPy7LNYefJ1w9awmFfINmHPhw1Q9BntUzhGfjPr159l+MXIDcLJaKZBooT2qjTNM8Q Zqpu9qGy9sWlsDLEkbjqD9fNppgIdwGRa9uogN20pEZ3k7ItLXSGTd8tGGCtcnyDZyb6 ZJ/hY0YrrTroi2hPTx5E0rAgSGL8nCKcDN8zNpSzZ0heb2OCM8JdYJL5698LoAyHBU9w yu+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758621062; x=1759225862; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=V4giJWC/+uACYkH8OgTwb0xX9epOJOFH20WVIPjHeQA=; b=Di8zmoCnEp79lEBAfizM50IVMTcB8s80hRsdfa0eOWsHF/vTne5PFKZ/bCyDBWyWyg 2nhEwnqPjmYadQaLqYdLsdVqQA1B2ovk7GiLWmPtKPB0/uELe4YQYFJadsBn+8j0Kzg9 JV5CAi7mmBYHTDTRJqa/CwwP6Xj1H6xMr/ICPpGMfbKkGJ6p6ASM22vPNWoHcvWHcYzI juf4SOjcRHvnIi8v1uj2Ih12wxo4E7BkobkL9OnwqruJxbXilQNippxJ4jWMUjd8gbDh YuFZRimHzlPotJeqhPzhVoRREUR5PiiVpZ4mpaQ1i2ZmTLpMQuMKiOpaBJoVlCGn0nb9 kLPg== X-Forwarded-Encrypted: i=1; AJvYcCUc/ebqzvQU06oHdba9Q43Ec5sPJak5T2IoBLD84V1DeIKoGlB+qOomGzFdJxmzPO4lsz+VjuZwtiRLdTn+ujSmycJ+@freebsd.org X-Gm-Message-State: AOJu0Ywqqz6YuY8jtsffyELw4c5R7/BHY0VXA51kUTLtb3B+8eN3mCFf vdC8+jRvHJHd6uJSotPxrCRcwCg1UPSG2713dc1EhxQ6iQlmhUKkERGnDSrTzZtMvfYB1Ho9Q7G EGlGkThe2YpY74GDkf4InSIXopg4ObVs= X-Gm-Gg: ASbGncv2rw3qjHaKhqw03o4cYtEAObrXqadMqWEh2qSx0M672YpIgg/fb6sB2rYoE0N 4Ur1a9mYi7ibHjdp7A3DJ5ygQqyjcNsPyZbVSAGXeSMhiJAgHpGcyIrWs9vH8ETtGG5V4viBdwz DPPfAz1qpHbvsA+MjVE9IC4SqxGkz2tT70fnO2SjhcqK96j3hPXoUWrrNkvFAbD4jjq5E9fZ3xW kr5RmpIdcBCpnYI4G1471CZ+YlwUrlIujxpow== X-Google-Smtp-Source: AGHT+IHXYSJAOdQyatTZQ9a9DHt8PgSmTLwIe8EgP9G69ho0wEYqOMIrq7k7sEeQ8wNHXnXMvzdRFmsk8dFWqsf5ol8= X-Received: by 2002:a05:6402:2682:b0:62f:b45d:2191 with SMTP id 4fb4d7f45d1cf-634678057acmr1760061a12.33.1758621062328; Tue, 23 Sep 2025 02:51:02 -0700 (PDT) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 References: <202509191419.58JEJsvj031867@gitrepo.freebsd.org> <92831372-745d-4612-b38f-aeb235dd8cca@FreeBSD.org> In-Reply-To: From: Mateusz Guzik Date: Tue, 23 Sep 2025 11:50:49 +0200 X-Gm-Features: AS18NWCax9YlSMN1vp1BB_64vBiDcvf_iFXJfL-3vDSZ7Fdr4ri30QuCkmq1jw0 Message-ID: Subject: Re: git: 40a42785dbba - main - fcntl(F_SETFL): only allow one thread to perform F_SETFL To: Konstantin Belousov Cc: John Baldwin , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Rspamd-Queue-Id: 4cWFbw65rjz45y5 On Mon, Sep 22, 2025 at 11:05=E2=80=AFPM Konstantin Belousov wrote: > > > On 9/22/25 13:40, Mateusz Guzik wrote: > > > Per my previous e-mail the offset lock is already contested. > I am curious how they are? > If several threads do read(2)/write(2) kind of io on the same fd, > they get what they deserve. > I don't know who, I had seen them with poudriere: https://people.freebsd.org/~mjg/poudriere-offcpu-32kpkg.svg?s=3Dvofflock Note the % would be higher if it was not for other problems. > > > > > > Using a pool over a lock embedded into the struct would hinder perfor= mance. > > > > > > I explained why I don't consider embedding sx into struct file to be = a problem. > > Are you saying that struct file falls into 128-byte zone, and has enough > space for sx? It is 80 bytes now. adding 32 still leaves 16 bytes free.