Date: Wed, 16 Aug 2023 20:26:34 +0200 From: Felix Palmen <zirias@freebsd.org> To: ports@freebsd.org Subject: Re: plist-check not reporting orphaned files present in a @comment Message-ID: <2ppfted4t72jo2bhgxfmoghpm6zukhrcqevucxvouqqwehwugg@zy4chydjtuxy> In-Reply-To: <8raa-vofq-wny@FreeBSD.org> References: <5h3c6jbzs7y5k3hyimqn7jkyo3se3txvcywahpcffzc24hjew7@kx4mhnqq7gh4> <8raa-vofq-wny@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--ekvwxsovuaepvv25 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable * Jan Beich <jbeich@FreeBSD.org> [20230816 20:20]: > Looks intentional per https://cgit.freebsd.org/ports/commit/?id=3De15449a= 9eff5 >=20 > > - Fix showing files installed through unselected OPTIONS as orphans, > > by considering "@comment file" to be ignored. [2] > [...] > > [2] This is a partial solution, we may still need a plist.ignore too. It > > doesn't make much sense to add files in main pkg-plist we don't car= e about, > > but maybe it does since you'll see and reconsider them being ignored > > someday. @comment is used as all the OPTION PLIST_SUB deactivations= use > > @comment instead of something like @ignore. Oh boy. I could have sworn it "worked" before, but this proves me wrong, thanks for the pointer! Yes, this is at best a partial solution. It's probably fine for options cause there's always the case that something *is* built/installed by the upstream build system and you still don't want to package it. It really breaks things for my current use case though. Well, I have a workaround, do test builds with "pre-filtered" pkg-plist. Someone should have another look at that some day. Maybe me, haha ... --=20 Felix Palmen <zirias@FreeBSD.org> {private} felix@palmen-it.de -- ports committer -- {web} http://palmen-it.de {pgp public key} http://palmen-it.de/pub.txt {pgp fingerprint} 6936 13D5 5BBF 4837 B212 3ACC 54AD E006 9879 F231 --ekvwxsovuaepvv25 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iNUEABYKAH0WIQRpNhPVW79IN7ISOsxUreAGmHnyMQUCZN0U2V8UgAAAAAAuAChp c3N1ZXItZnByQG5vdGF0aW9ucy5vcGVucGdwLmZpZnRoaG9yc2VtYW4ubmV0Njkz NjEzRDU1QkJGNDgzN0IyMTIzQUNDNTRBREUwMDY5ODc5RjIzMQAKCRBUreAGmHny MdxjAQC0JZTvXzQbzn+itbO59ubBbhfIv4E5OfhmuX2daT529gD8C4f26FDYrafU j8zBrYx1ETc0v+Kwcy+/ijBK6ewfXws= =EwhW -----END PGP SIGNATURE----- --ekvwxsovuaepvv25--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?2ppfted4t72jo2bhgxfmoghpm6zukhrcqevucxvouqqwehwugg>