Date: Tue, 27 Nov 2012 15:31:07 +0200 From: Alex Kozlov <ak@FreeBSD.org> To: Alexey Dokuchaev <danfe@FreeBSD.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r307837 - head/comms/morse Message-ID: <20121127133107.GA740@ravenloft.kiev.ua> In-Reply-To: <20121127125610.GA59490@FreeBSD.org> References: <201211271205.qARC54XQ060171@svn.freebsd.org> <20121127125610.GA59490@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Nov 27, 2012 at 12:56:10PM +0000, Alexey Dokuchaev wrote: > On Tue, Nov 27, 2012 at 12:05:04PM +0000, Alex Kozlov wrote: > > New Revision: 307837 > > URL: http://svnweb.freebsd.org/changeset/ports/307837 > > > > +# Created by: Stephen Hurd <shurd@sasktel.net> > Space, not tab please. That's ironic, I even have patch for portlint which adds check for space afrer Created by/WWW. > > +OSS_DESC= Beep using OSS (/dev/dsp) > > +X11_DESC= Beep using X server > > +PA_DESC= Beep using Pulse Audio > All of these options are already in bsd.options.desc.mk (PA_DESC is named > PULSEAUDIO_DESC though). While you might want to adjust their descriptions, > at least we should not invent new names for existing features. I suppose I can change PA_DESC to PULSEAUDIO_DESC, but it's not really matter, because in this case specific descriptions are better and I'm not going to use generic ones from bsd.options.desc.mk. -- Alex
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20121127133107.GA740>