From owner-freebsd-doc@FreeBSD.ORG  Sun Dec 14 09:30:21 2003
Return-Path: <owner-freebsd-doc@FreeBSD.ORG>
Delivered-To: freebsd-doc@hub.freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id B81DE16A4CE
	for <freebsd-doc@hub.freebsd.org>;
	Sun, 14 Dec 2003 09:30:21 -0800 (PST)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id AD9A043D1F
	for <freebsd-doc@hub.freebsd.org>;
	Sun, 14 Dec 2003 09:30:19 -0800 (PST)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	hBEHUJFR024861	for <freebsd-doc@freefall.freebsd.org>;
	Sun, 14 Dec 2003 09:30:19 -0800 (PST)
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.12.10/8.12.10/Submit) id hBEHUJrs024860;
	Sun, 14 Dec 2003 09:30:19 -0800 (PST)
	(envelope-from gnats)
Date: Sun, 14 Dec 2003 09:30:19 -0800 (PST)
Message-Id: <200312141730.hBEHUJrs024860@freefall.freebsd.org>
To: freebsd-doc@FreeBSD.org
From: Josef El-Rayes <josef@daemon.li>
Subject: Re: docs/60107: [PATCH] update sample code in PCI driver chapter of
	arch handbook
X-BeenThere: freebsd-doc@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
Reply-To: Josef El-Rayes <josef@daemon.li>
List-Id: Documentation project <freebsd-doc.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-doc>,
	<mailto:freebsd-doc-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-doc>
List-Post: <mailto:freebsd-doc@freebsd.org>
List-Help: <mailto:freebsd-doc-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-doc>,
	<mailto:freebsd-doc-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 14 Dec 2003 17:30:21 -0000

The following reply was made to PR docs/60107; it has been noted by GNATS.

From: Josef El-Rayes <josef@daemon.li>
To: Lukas Ertl <l.ertl@univie.ac.at>
Cc: FreeBSD-gnats-submit@FreeBSD.org
Subject: Re: docs/60107: [PATCH] update sample code in PCI driver chapter of arch handbook
Date: Wed, 10 Dec 2003 10:00:36 +0000

 Lukas Ertl <l.ertl@univie.ac.at> wrote:
 > +#include &lt;sys/param.h&gt;  /* defines used in kernel.h */
 > -#include &lt;sys/param.h&gt;  /* defines used in kernel.h */
 
 hi lukas!
 
 it is a good idea to have a look at the diff-generated patch
 before sending in, to avoid bogus lines like this.
 
 for example when you move a line(i.e. remove & insert at another
 place), you get such behaviour in your patch which makes it hard to read.
 
 keep up the good work :)
 greets, josef