From owner-freebsd-atm Tue Feb 11 12:39: 1 2003 Delivered-To: freebsd-atm@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id F2ECB37B401 for ; Tue, 11 Feb 2003 12:39:00 -0800 (PST) Received: from mel-rto2.wanadoo.fr (smtp-out-2.wanadoo.fr [193.252.19.254]) by mx1.FreeBSD.org (Postfix) with ESMTP id DC0A243F3F for ; Tue, 11 Feb 2003 12:38:59 -0800 (PST) (envelope-from vjardin@wanadoo.fr) Received: from mel-rta7.wanadoo.fr (193.252.19.61) by mel-rto2.wanadoo.fr (6.7.015) id 3E0C337001D71410; Tue, 11 Feb 2003 21:38:52 +0100 Received: from there (80.11.204.72) by mel-rta7.wanadoo.fr (6.7.015) id 3E26CE540106EDD2; Tue, 11 Feb 2003 21:38:52 +0100 Message-ID: <3E26CE540106EDD2@mel-rta7.wanadoo.fr> (added by postmaster@wanadoo.fr) Content-Type: text/plain; charset="iso-8859-1" From: Vincent Jardin To: Harti Brandt , atm@freebsd.org Subject: Re: Bug in hea driver? Date: Tue, 11 Feb 2003 21:59:40 +0100 X-Mailer: KMail [version 1.3.2] References: <20030211112002.S3497@beagle.fokus.gmd.de> In-Reply-To: <20030211112002.S3497@beagle.fokus.gmd.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: owner-freebsd-atm@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org I agree with this patch. Vincent Le Mardi 11 Février 2003 11:23, Harti Brandt a écrit : > Hi all, > > could someone please comment on the attached patch? There seems to be a > bug in the on-card memory allocator. The problem is, that when we need to > split a block that appears to be large enough because of alignment, we > want to check, that what remains after splitting is large enough (with > regard to the size we are trying to allocated), not that it is >= 0. The > test for >= 0 should always be true, because a block of size N (N beeing a > power of two) always contains an address that is aligned to N, so that the > upper half when splitting such a block is always >= 0. > > harti To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-atm" in the body of the message