Date: Sun, 6 Dec 2009 11:50:04 GMT From: Dominik Ernst <dernst@gmx.de> To: freebsd-fs@FreeBSD.org Subject: Re: kern/141177: [zfs] fsync() on FIFO causes panic() on zfs Message-ID: <200912061150.nB6Bo47v020711@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR kern/141177; it has been noted by GNATS.
From: Dominik Ernst <dernst@gmx.de>
To: Kostik Belousov <kostikbel@gmail.com>
Cc: bug-followup@freebsd.org
Subject: Re: kern/141177: [zfs] fsync() on FIFO causes panic() on zfs
Date: Sun, 6 Dec 2009 12:20:55 +0100
Thanks that seems to work as far as i can tell.
On Sat, 5 Dec 2009 01:41:31 +0200
Kostik Belousov <kostikbel@gmail.com> wrote:
> ZFS explicitely puts VOP_PANIC as fsync vop for fifos. I think
> the following patch fixes it.
>
> diff --git
> a/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_vnops.c
> b/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_vnops.c index
> 7608d76..4f61f5f 100644 ---
> a/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_vnops.c +++
> b/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_vnops.c @@
> -5009,7 +5009,7 @@ struct vop_vector zfs_vnodeops = { struct
> vop_vector zfs_fifoops = { .vop_default =
> &fifo_specops,
> - .vop_fsync = VOP_PANIC,
> + .vop_fsync = zfs_freebsd_fsync,
> .vop_access = zfs_freebsd_access,
> .vop_getattr = zfs_freebsd_getattr,
> .vop_inactive = zfs_freebsd_inactive,
>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200912061150.nB6Bo47v020711>