From nobody Wed Dec 15 11:16:46 2021 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id C753B18E9AD7; Wed, 15 Dec 2021 11:16:49 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4JDXkl0mPzz4qrY; Wed, 15 Dec 2021 11:16:46 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 86F691AF38; Wed, 15 Dec 2021 11:16:46 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 1BFBGk3v081726; Wed, 15 Dec 2021 11:16:46 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 1BFBGkIC081725; Wed, 15 Dec 2021 11:16:46 GMT (envelope-from git) Date: Wed, 15 Dec 2021 11:16:46 GMT Message-Id: <202112151116.1BFBGkIC081725@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Andriy Gapon Subject: git: 25e92673b54e - main - rk_i2c_transfer: minor improvement to bit twiddling List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: avg X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 25e92673b54ea3b66cbaf53826cfd01df3441ea3 Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1639567007; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=gBOcA/NrRk0fqqkrA0uFFOtDaUIZIYv1y9n3LbDUpMI=; b=B/FNwGg926v6qDdPxyvUvHxY5X2MTzga7N6rk/eN2U8nhgXlNv7Y6q2grwZKpjO7zFbv7S +wXl+1UhWS4Dk11ZpzEW4E1+7VNvaonN5StGd3foRJ0eAMkTsO/mPJPGa1k1M1bJkV1/E+ ZOEYTYkvVYp8sU1mFfV5lrnjUVuLPnjn+ZRtXWMJQ5MV/38/xy2F7SxOMSQEH2i+SbVZg6 +6RzLYpkQvoa0cYkjUibJuP5Y76+ZiUjDj6yepbjYzU5iChhSZjc8K0ZLDjTJza04168I8 h/K8QaTKsfOjCWRqjXwICtc8WnKtKoFlZU3Uet8DkbbAIhW+xJhWnV05rAkMkA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1639567007; a=rsa-sha256; cv=none; b=IMkN28uSxe32hlVNexWi7rN3KT3Lz2bN6AxvNDEnBK4Mhsie9heaGlm/OIOF+inwp5Q9kc ygmROgIA1pFtH+r9lCayhMa86CPow+Js4TWc7XVD++pS/aO9VdYLVyxoYxa/lb3Mg6fQC1 D8uHHmSyVvounVmjoC6PN9CByifaPfea8CWFRVw6dJEX5ny0ITYAJHv6VeHeyfBGn4URvk r3MGJHCUxN3AjJuEpMDoRBR3xeothtr1McGtvWntN9tmxBP6+OjqS3gUg5gj8qGk4h8XHR qGYo6II9TYW1UH9e2N3mtQlTEdczd3dcMwsNRsABaiPKOkcVV6H1paQk9Phehg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by avg: URL: https://cgit.FreeBSD.org/src/commit/?id=25e92673b54ea3b66cbaf53826cfd01df3441ea3 commit 25e92673b54ea3b66cbaf53826cfd01df3441ea3 Author: Andriy Gapon AuthorDate: 2021-12-15 09:11:15 +0000 Commit: Andriy Gapon CommitDate: 2021-12-15 11:16:09 +0000 rk_i2c_transfer: minor improvement to bit twiddling No need to mask a uint8_t with 0xff, the mask covers the whole type. Explcitly cast to uint32_t before bit shifting instead of relying on the implicit promotion to signed int. MFC after: 1 week --- sys/arm64/rockchip/rk_i2c.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/arm64/rockchip/rk_i2c.c b/sys/arm64/rockchip/rk_i2c.c index ef41044e65cb..6ad168f0c64c 100644 --- a/sys/arm64/rockchip/rk_i2c.c +++ b/sys/arm64/rockchip/rk_i2c.c @@ -524,7 +524,7 @@ rk_i2c_transfer(device_t dev, struct iic_msg *msgs, uint32_t nmsgs) /* Write slave register address */ reg = 0; for (j = 0; j < msgs[i].len ; j++) { - reg |= (msgs[i].buf[j] & 0xff) << (j * 8); + reg |= (uint32_t)msgs[i].buf[j] << (j * 8); reg |= RK_I2C_MRXADDR_VALID(j); } RK_I2C_WRITE(sc, RK_I2C_MRXRADDR, reg);