From owner-cvs-all Fri Jul 30 18:52: 9 1999 Delivered-To: cvs-all@freebsd.org Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21]) by hub.freebsd.org (Postfix) with ESMTP id 7166314D2E; Fri, 30 Jul 1999 18:52:03 -0700 (PDT) (envelope-from msmith@FreeBSD.org) Received: (from msmith@localhost) by freefall.freebsd.org (8.9.3/8.9.2) id SAA89352; Fri, 30 Jul 1999 18:52:00 -0700 (PDT) (envelope-from msmith@FreeBSD.org) Message-Id: <199907310152.SAA89352@freefall.freebsd.org> From: Mike Smith Date: Fri, 30 Jul 1999 18:52:00 -0700 (PDT) To: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: src/sys/nfs nfs_vnops.c Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk msmith 1999/07/30 18:52:00 PDT Modified files: sys/nfs nfs_vnops.c Log: As described by the submitter: I did some tcpdumping the other day and noticed that GETATTR calls were frequently followed by an ACCESS call to the same file. The attached patch changes nfs_getattr to fill the access cache as a side effect. This is accomplished by calling ACCESS rather than GETATTR. This implies a modest overhead of 4 bytes in the request and 8 bytes in the response compared to doing a vanilla GETATTR. ... [The patch comprises two parts] The first is the "real" patch, the second counts misses and hits rather than fills and hits. The difference is subtle but important because both nfs_getattr and nfs_access now fill the cache. It also changes the default value of nfsaccess_cache_timeout to better match the attribute cache. IMHO, file timestamps change much more frequently than protection bits. Submitted by: Bjoern Groenvall Reviewed by: dillon (partially) Revision Changes Path 1.138 +55 -34 src/sys/nfs/nfs_vnops.c To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message