From owner-svn-src-all@FreeBSD.ORG  Wed Oct 10 19:46:47 2012
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
 by hub.freebsd.org (Postfix) with ESMTP id 2F76A696;
 Wed, 10 Oct 2012 19:46:47 +0000 (UTC) (envelope-from mav@FreeBSD.org)
Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c])
 by mx1.freebsd.org (Postfix) with ESMTP id 180698FC0A;
 Wed, 10 Oct 2012 19:46:47 +0000 (UTC)
Received: from svn.freebsd.org (localhost [127.0.0.1])
 by svn.freebsd.org (8.14.4/8.14.4) with ESMTP id q9AJkklg089027;
 Wed, 10 Oct 2012 19:46:46 GMT (envelope-from mav@svn.freebsd.org)
Received: (from mav@localhost)
 by svn.freebsd.org (8.14.4/8.14.4/Submit) id q9AJkkvx089025;
 Wed, 10 Oct 2012 19:46:46 GMT (envelope-from mav@svn.freebsd.org)
Message-Id: <201210101946.q9AJkkvx089025@svn.freebsd.org>
From: Alexander Motin <mav@FreeBSD.org>
Date: Wed, 10 Oct 2012 19:46:46 +0000 (UTC)
To: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Subject: svn commit: r241413 - head/sys/kern
X-SVN-Group: head
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 10 Oct 2012 19:46:47 -0000

Author: mav
Date: Wed Oct 10 19:46:46 2012
New Revision: 241413
URL: http://svn.freebsd.org/changeset/base/241413

Log:
  panic() with reasonable message instead of returning zero frequency causing
  division by zero later if event timer's minimal period is above one second.
  For now it is just a theoretical possibility.
  
  Found by:	Clang Static Analyzer

Modified:
  head/sys/kern/kern_clocksource.c

Modified: head/sys/kern/kern_clocksource.c
==============================================================================
--- head/sys/kern/kern_clocksource.c	Wed Oct 10 19:43:45 2012	(r241412)
+++ head/sys/kern/kern_clocksource.c	Wed Oct 10 19:46:46 2012	(r241413)
@@ -602,7 +602,8 @@ round_freq(struct eventtimer *et, int fr
 		freq = (et->et_frequency + div / 2) / div;
 	}
 	if (et->et_min_period.sec > 0)
-		freq = 0;
+		panic("Event timer \"%s\" doesn't support sub-second periods!",
+		    et->et_name);
 	else if (et->et_min_period.frac != 0)
 		freq = min(freq, BT2FREQ(&et->et_min_period));
 	if (et->et_max_period.sec == 0 && et->et_max_period.frac != 0)