From owner-svn-src-all@FreeBSD.ORG  Tue Jun 15 20:18:51 2010
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id DC232106564A;
	Tue, 15 Jun 2010 20:18:50 +0000 (UTC)
	(envelope-from jfvogel@gmail.com)
Received: from mail-qy0-f182.google.com (mail-qy0-f182.google.com
	[209.85.216.182])
	by mx1.freebsd.org (Postfix) with ESMTP id 337168FC08;
	Tue, 15 Jun 2010 20:18:49 +0000 (UTC)
Received: by qyk11 with SMTP id 11so1015580qyk.13
	for <multiple recipients>; Tue, 15 Jun 2010 13:18:49 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
	h=domainkey-signature:mime-version:received:received:in-reply-to
	:references:date:message-id:subject:from:to:cc:content-type;
	bh=8m9XApBihncBZgP8qDSRjNhhVazwQ1aU4Nc+oxjfxZ0=;
	b=nQA7mVu9Uq+PFs6xyj5YXu2CRAQa+3z/Y5yN/ForcRNiwp/lLobDryhU/9x1if3x7m
	Ttc9/K/3TcBNJ01QaCJth3HmuoWriiFAlC/H14WOuVvj1/89tOFuKohX3DDq3rKnFoin
	i1Ja5lKg0Rj8BZsmArioOaoYUy4RSXuKavp6E=
DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma;
	h=mime-version:in-reply-to:references:date:message-id:subject:from:to
	:cc:content-type;
	b=XhGq7sAEpqgdzyE+GxRgsJx9Sfee4ac+dJNP0U268bre9cQYUDBLAJzR0CawjHdWDy
	QHxl8ztPBNLMlCGr54h6uPSz+u1zpgZOOSBSOeHQ8SFJaGa9XDdpxJEHBlyBWVdbwqDK
	sG9Gfr9khfIpgjNCFqgluvP7+SVuHA+QKaBSI=
MIME-Version: 1.0
Received: by 10.224.66.206 with SMTP id o14mr3523053qai.264.1276633129283; 
	Tue, 15 Jun 2010 13:18:49 -0700 (PDT)
Received: by 10.229.246.65 with HTTP; Tue, 15 Jun 2010 13:18:49 -0700 (PDT)
In-Reply-To: <201006151549.09210.jhb@freebsd.org>
References: <201006112054.o5BKsRk8087302@svn.freebsd.org>
	<201006151549.09210.jhb@freebsd.org>
Date: Tue, 15 Jun 2010 13:18:49 -0700
Message-ID: <AANLkTimbg4u9wk51bCv6cJDAjuHzpevbSjCMSV6N2ame@mail.gmail.com>
From: Jack Vogel <jfvogel@gmail.com>
To: John Baldwin <jhb@freebsd.org>
Content-Type: text/plain; charset=ISO-8859-1
X-Content-Filtered-By: Mailman/MimeDel 2.1.5
Cc: Jack F Vogel <jfv@freebsd.org>, svn-src-head@freebsd.org,
	svn-src-all@freebsd.org, src-committers@freebsd.org
Subject: Re: svn commit: r209068 - head/sys/dev/e1000
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 15 Jun 2010 20:18:51 -0000

Ahhh, thanks for report John, will fix that asap.

Jack


On Tue, Jun 15, 2010 at 12:49 PM, John Baldwin <jhb@freebsd.org> wrote:

> On Friday 11 June 2010 4:54:27 pm Jack F Vogel wrote:
> > Author: jfv
> > Date: Fri Jun 11 20:54:27 2010
> > New Revision: 209068
> > URL: http://svn.freebsd.org/changeset/base/209068
> >
> > Log:
> >   Add a couple fixes from Michael Tuexen.
> >   Remove unneeded rxtx handler, make que handler generic.
> >   Do not allocate header mbufs in rx ring if not doing hdr split.
> >   Release the lock in rxeof call to stack.
> >
> >   MFC for 8.1 asap
>
> This causes a panic with MSIX is disabled (boot with
> hw.pci.msix_enabled=0).
> The reason is that in the !MSIX case, the rxtx_task is queued to the
> adapter->tq queue, but in the MSIX case the task is queued to the per-queue
> que->tq queue.  igb_handle_que() assumes the MSIX case, it is not generic.
>
> --
> John Baldwin
>