From owner-svn-src-all@freebsd.org  Mon Jan 30 23:02:02 2017
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 05572CC84C5;
 Mon, 30 Jan 2017 23:02:02 +0000 (UTC)
 (envelope-from glebius@FreeBSD.org)
Received: from cell.glebi.us (glebi.us [96.95.210.25])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "cell.glebi.us", Issuer "cell.glebi.us" (not verified))
 by mx1.freebsd.org (Postfix) with ESMTPS id 71CB476F;
 Mon, 30 Jan 2017 23:02:01 +0000 (UTC)
 (envelope-from glebius@FreeBSD.org)
Received: from cell.glebi.us (localhost [127.0.0.1])
 by cell.glebi.us (8.15.2/8.15.2) with ESMTPS id v0UN20wb061288
 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO);
 Mon, 30 Jan 2017 15:02:00 -0800 (PST)
 (envelope-from glebius@FreeBSD.org)
Received: (from glebius@localhost)
 by cell.glebi.us (8.15.2/8.15.2/Submit) id v0UN20c6061287;
 Mon, 30 Jan 2017 15:02:00 -0800 (PST)
 (envelope-from glebius@FreeBSD.org)
X-Authentication-Warning: cell.glebi.us: glebius set sender to
 glebius@FreeBSD.org using -f
Date: Mon, 30 Jan 2017 15:02:00 -0800
From: Gleb Smirnoff <glebius@FreeBSD.org>
To: Edward Tomasz Napierala <trasz@FreeBSD.org>
Cc: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Subject: Re: svn commit: r312988 - in head/sys: compat/cloudabi compat/linux
 kern sys
Message-ID: <20170130230200.GD2611@FreeBSD.org>
References: <201701301257.v0UCvNrK065993@repo.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201701301257.v0UCvNrK065993@repo.freebsd.org>
User-Agent: Mutt/1.7.2 (2016-11-26)
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 30 Jan 2017 23:02:02 -0000

On Mon, Jan 30, 2017 at 12:57:23PM +0000, Edward Tomasz Napierala wrote:
E> Author: trasz
E> Date: Mon Jan 30 12:57:22 2017
E> New Revision: 312988
E> URL: https://svnweb.freebsd.org/changeset/base/312988
E> 
E> Log:
E>   Add kern_listen(), kern_shutdown(), and kern_socket(), and use them
E>   instead of their sys_*() counterparts in various compats. The svr4
E>   is left untouched, because there's no point.

Btw, any good reasons to keep SVR4 support for FreeBSD 12?

I recently reviewed some socket code and noticed, that having SVR4-compatible
sockets we need COMPAT_OLDSOCK to be compiled in, which isn't in GENERIC, of
course. Thus doing just 'kldload svr4' on GENERIC won't allow to create
SVR4 compatible sockets. Not even mentioning that COMPAT_OLDSOCK is probably
broken since nobody needs it and it has no regression tests.

-- 
Totus tuus, Glebius.