From nobody Mon Feb 9 16:40:03 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4f8r5s2n9Gz6Rh7v for ; Mon, 09 Feb 2026 16:40:17 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4f8r5r71KSz3YYc for ; Mon, 09 Feb 2026 16:40:16 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-4806cc07ce7so47099375e9.1 for ; Mon, 09 Feb 2026 08:40:16 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770655215; x=1771260015; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=TdAiVe/5jQXy442BD+f3zvoCalQ1juUP12AHFGkEBJE=; b=uMIbUKwAFsA5IGoG7umCeO7jGi8AFaRZVCY/zdk4hl50TQUNpOwNiYzTtKdZD3cHub 8TVt0BIU6/c/yUnQ885K2SnmiaOTwEcadBjtkKz3QIwrnjMtfgfO5XHj4dkWICtO77+v 7Dy+O/UgSUz3xkB5ad/pNrXr2x331yx+CYPPHjEiCnkdhf4U0LneZQiFLNbN8roxjjiw 4k6Qwfo7YTN3n5l1stWHjsPs32LaBcaEUFSQ4WQgW/MwO4BDwJuomy2szWrC1+Gud4+b Kl1WRcmMOVtYBWDyHz89YrZSr0dhES/rIcB/lcb+V/z0jeWOe2SkYiRtLRFAaoyA3kSL nWOQ== X-Forwarded-Encrypted: i=1; AJvYcCUHfeb94MB+WA2ZWhB9+TomI6bwSEuLCdz5VbeB31zPZ8SFtoPxlz4zmDiXSqkucS7umtuihzsoBBHoYOY75whBRf6q@freebsd.org X-Gm-Message-State: AOJu0YxAczEHzBHX2xqgbuf0IN1jDAMlqQg12eoierA5nstmHbv64/9m uT8k2WnX2ksECLkm7KQpwDtTM8IHAB21CZFdX0yAeoR8cGJre/CpaksIGzOuEMu7ybFtgex3o/6 IwuFm X-Gm-Gg: AZuq6aIIZEHyEl6UrwYJx3UkKgIamy6hy5V45XOlshfJZW8daeeyt8PoPj4X/v5ucTU 2EQlm4R6Zr6D8REqdPTwQqD0VEMTnQZ0IZPzxqSTRkBsUVVq5NEWCmgUuczuQCz200lkPmn3MnA wxs1McbNHpmHXM32WWtvJ9xvjPy566CxePDyBBl/CnnQQe1QH6PAqaAJsnCfpZXsgaVdJl2TAaH LBY/se9uc+01nIMfTPPxoNxO/LJHxwYfLXpfPdStVdpmsNx8Nu+NRRyzWPUATUPGIFIMYj+kdif k8BnjneUAM8FjYq65arffAN8u3OF+I8e7N0HxlagwAGc2lZeYccOONCb7RGm5w1LK1bEO3PaKBj p2stcgS3AHmbX85J07HFqWHod9i9OeOq82MMHDYgzzpe3LBb0Do9E+1JHMEyzsG5H+SucG2OQJy bUBZnl2bgXQgWH0YLKIxl483pZhE6JXFVEiCrPMdqIN3RIodh745pJAA== X-Received: by 2002:a05:600c:6290:b0:483:a21:774a with SMTP id 5b1f17b1804b1-48320225afemr187285115e9.26.1770655215005; Mon, 09 Feb 2026 08:40:15 -0800 (PST) Received: from smtpclient.apple (nat-184-7.net.cam.ac.uk. [131.111.184.7]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4834d5ebd1bsm1041005e9.6.2026.02.09.08.40.13 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 09 Feb 2026 08:40:14 -0800 (PST) Content-Type: text/plain; charset=utf-8 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3864.300.41.1.7\)) Subject: Re: git: ee73475119ff - main - llvm: Link private LLVM libraries against compiler_rt for aarch64 From: Jessica Clarke In-Reply-To: <698a0b1e.1d294.40e36519@gitrepo.freebsd.org> Date: Mon, 9 Feb 2026 16:40:03 +0000 Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Content-Transfer-Encoding: quoted-printable Message-Id: References: <698a0b1e.1d294.40e36519@gitrepo.freebsd.org> To: John Baldwin X-Mailer: Apple Mail (2.3864.300.41.1.7) X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US] X-Rspamd-Queue-Id: 4f8r5r71KSz3YYc X-Spamd-Bar: ---- On 9 Feb 2026, at 16:28, John Baldwin wrote: >=20 > The branch main has been updated by jhb: >=20 > URL: = https://cgit.FreeBSD.org/src/commit/?id=3Dee73475119ff7aa98bd11828625d524f= 6ab87f06 >=20 > commit ee73475119ff7aa98bd11828625d524f6ab87f06 > Author: John Baldwin > AuthorDate: 2026-02-09 16:26:52 +0000 > Commit: John Baldwin > CommitDate: 2026-02-09 16:26:52 +0000 >=20 > llvm: Link private LLVM libraries against compiler_rt for aarch64 >=20 > This is required for GCC which uses libcalls for outlined atomics. This doesn=E2=80=99t seem right, they=E2=80=99re provided by libgcc.a, = so why aren=E2=80=99t they being pulled in? libcompiler_rt.a doesn=E2=80=99t even have the = symbols. Jessica > Reviewed by: dim > Differential Revision: https://reviews.freebsd.org/D55157 > --- > lib/clang/libclang/Makefile | 4 ++++ > lib/clang/liblldb/Makefile | 4 ++++ > lib/clang/libllvm/Makefile | 4 ++++ > 3 files changed, 12 insertions(+) >=20 > diff --git a/lib/clang/libclang/Makefile b/lib/clang/libclang/Makefile > index 56f6fd374fe5..1b24d5cbf4cf 100644 > --- a/lib/clang/libclang/Makefile > +++ b/lib/clang/libclang/Makefile > @@ -14,6 +14,10 @@ PRIVATELIB=3D > # Work around "relocation R_PPC_GOT16 out of range" errors > PICFLAG=3D -fPIC > .endif > +.if ${MACHINE_CPUARCH} =3D=3D "aarch64" > +# Only required for GCC > +LIBADD+=3D compiler_rt > +.endif > .endif >=20 > SHARED_CXXFLAGS+=3D -UPIC # To avoid compile errors > diff --git a/lib/clang/liblldb/Makefile b/lib/clang/liblldb/Makefile > index aa9e90b2f6f2..b2da21c2990e 100644 > --- a/lib/clang/liblldb/Makefile > +++ b/lib/clang/liblldb/Makefile > @@ -10,6 +10,10 @@ PACKAGE=3D lldb > SHLIB_CXX=3D lldb > SHLIB_MAJOR=3D 19 > PRIVATELIB=3D > +.if ${MACHINE_CPUARCH} =3D=3D "aarch64" > +# Only required for GCC > +LIBADD+=3D compiler_rt > +.endif > .endif >=20 > SHARED_CXXFLAGS+=3D -UPIC # To avoid compile errors > diff --git a/lib/clang/libllvm/Makefile b/lib/clang/libllvm/Makefile > index 05128550827a..9b2a272d2c67 100644 > --- a/lib/clang/libllvm/Makefile > +++ b/lib/clang/libllvm/Makefile > @@ -14,6 +14,10 @@ PRIVATELIB=3D > # Work around "relocation R_PPC_GOT16 out of range" errors > PICFLAG=3D -fPIC > .endif > +.if ${MACHINE_CPUARCH} =3D=3D "aarch64" > +# Only required for GCC > +LIBADD+=3D compiler_rt > +.endif > CFLAGS+=3D -DLLVM_BUILD_LLVM_DYLIB > .endif >=20 >=20