From owner-freebsd-stable@FreeBSD.ORG Fri Nov 21 19:16:48 2008 Return-Path: Delivered-To: stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 52F29106564A for ; Fri, 21 Nov 2008 19:16:48 +0000 (UTC) (envelope-from max@love2party.net) Received: from moutng.kundenserver.de (moutng.kundenserver.de [212.227.126.171]) by mx1.freebsd.org (Postfix) with ESMTP id DDE818FC12 for ; Fri, 21 Nov 2008 19:16:47 +0000 (UTC) (envelope-from max@love2party.net) Received: from vampire.homelinux.org (dslb-088-066-059-171.pools.arcor-ip.net [88.66.59.171]) by mrelayeu.kundenserver.de (node=mrelayeu8) with ESMTP (Nemesis) id 0ML31I-1L3bUk14kv-0007qt; Fri, 21 Nov 2008 20:16:46 +0100 Received: (qmail 3492 invoked from network); 21 Nov 2008 19:16:45 -0000 Received: from fbsd8.laiers.local (192.168.4.151) by ns1.laiers.local with SMTP; 21 Nov 2008 19:16:45 -0000 From: Max Laier Organization: FreeBSD To: Ulrich Spoerlein Date: Fri, 21 Nov 2008 20:16:44 +0100 User-Agent: KMail/1.10.1 (FreeBSD/8.0-CURRENT; KDE/4.1.1; i386; ; ) References: <20081120211148.GA5178@roadrunner.spoerlein.net> <1de79840811201456pc2ceb9atb3532430fb605160@mail.gmail.com> <20081121173933.GA2426@roadrunner.spoerlein.net> In-Reply-To: <20081121173933.GA2426@roadrunner.spoerlein.net> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200811212016.45474.max@love2party.net> X-Provags-ID: V01U2FsdGVkX194ebi3sJncFb13v23rVyiu+dDVfluz5Sovjim uxdZCqRLhC1pSSqKofw+xTBPB06PKgewtQY5ClOtaOYfTvxhja GK49QBU6gHXEOe+mRtV0A== Cc: Michael Proto , stable@freebsd.org, Max Laier Subject: Re: LORs in RELENG_7 X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Nov 2008 19:16:48 -0000 On Friday 21 November 2008 18:39:33 Ulrich Spoerlein wrote: > On Thu, 20.11.2008 at 17:56:07 -0500, Michael Proto wrote: > > On Thu, Nov 20, 2008 at 4:11 PM, Ulrich Spoerlein wrote: > > > Hi, > > > > > > I'm running my RELENG_7 kernel with WITNESS and there's always a LOR > > > when pf(4) is enabled: > > > > > > lock order reversal: > > > 1st 0xc09ca828 ifnet (ifnet) @ /usr/src/sys/net/if.c:849 > > > 2nd 0xc45d604c pf task mtx (pf task mtx) @ > > > /usr/src/sys/modules/pf/../../contrib/pf/net/pf_if.c:916 > > > KDB: stack backtrace: > > > db_trace_self_wrapper(c08df797,fb671764,c0630e8e,c08e1c96,c45d604c,...) > > > at db_trace_self_wrapper+0x26 > > > kdb_backtrace(c08e1c96,c45d604c,c45d3b1c,c45d3b1c,c45d379e,...) at > > > kdb_backtrace+0x29 > > > witness_checkorder(c45d604c,9,c45d379e,394,c08e9058,...) at > > > witness_checkorder+0x6de > > > _mtx_lock_flags(c45d604c,0,c45d379e,394,fb6717dc,...) at > > > _mtx_lock_flags+0xbc > > > pfi_attach_group_event(0,c4450000,c08e9058,374,c44a920c,...) at > > > pfi_attach_group_event+0x4e > > > if_addgroup(c441c000,c08f70d6,4,0,0,...) at if_addgroup+0x2c7 > > > if_clone_createif(0,0,c08e9563,87,0,...) at if_clone_createif+0x81 > > > if_clone_create(fb671943,4,0,44,180,...) at if_clone_create+0x8c > > > tunclone(0,c461e400,fb671943,4,fb67195c,...) at tunclone+0x17a > > > devfs_lookup(fb6719d0,fb6719d0,fb671b7c,c418de04,2,...) at > > > devfs_lookup+0x50e > > > VOP_LOOKUP_APV(c0928f40,fb6719d0,c412f230,c08e77ef,2a9,...) at > > > VOP_LOOKUP_APV+0xa5 > > > lookup(fb671b7c,c08e77ef,c6,bf,c461e92c,...) at lookup+0x58e > > > namei(fb671b7c,c412f230,fb671a74,246,c0983774,...) at namei+0x34b > > > vn_open_cred(fb671b7c,fb671c78,ce8,c461e400,c4460558,...) at > > > vn_open_cred+0x2c9 > > > vn_open(fb671b7c,fb671c78,ce8,c4460558,c05e807d,...) at vn_open+0x33 > > > kern_open(c412f230,80a0f18,0,3,808ecfa,...) at kern_open+0xe7 > > > open(c412f230,fb671cfc,c,c08e28c3,c092c0b8,...) at open+0x30 > > > syscall(fb671d38) at syscall+0x2b3 > > > Xint0x80_syscall() at Xint0x80_syscall+0x20 > > > --- syscall (5, FreeBSD ELF32, open), eip = 0x2835a65b, esp = > > > 0xbfbfeafc, ebp = 0xbfbfeb38 --- > > > > Are you using user or group rules in your pf.conf? IIRC there is still a > > known LOR in the socket layer with rules using the user or group filters. > > No, I'm aware of the problems with pf(4) and user/group rules. This LOR > is in combination with rules on tun(4) devices, as you can see from the > backtrace. I wonder what tunclone() is doing in there, though. This LOR is believed to be harmless. There should be an easy fix, even. I'll have to take a look over the weekend. -- /"\ Best regards, | mlaier@freebsd.org \ / Max Laier | ICQ #67774661 X http://pf4freebsd.love2party.net/ | mlaier@EFnet / \ ASCII Ribbon Campaign | Against HTML Mail and News