From owner-freebsd-arm@FreeBSD.ORG Wed May 13 15:45:37 2015 Return-Path: Delivered-To: freebsd-arm@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 2A500370 for ; Wed, 13 May 2015 15:45:37 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id E485C1DDD for ; Wed, 13 May 2015 15:45:36 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t4DFjaUJ070246 for ; Wed, 13 May 2015 15:45:36 GMT (envelope-from daemon-user@phabric-backend.isc.freebsd.org) Received: (from daemon-user@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t4DFjaTj070245; Wed, 13 May 2015 15:45:36 GMT (envelope-from daemon-user) Date: Wed, 13 May 2015 15:45:36 +0000 To: freebsd-arm@freebsd.org From: "andrew (Andrew Turner)" Subject: [Differential] [Commented On] D2340: Support for Alpine platform from Annapurna Labs Message-ID: <736b83acfa79ec54224ced60daf69b07@localhost.localdomain> X-Priority: 3 Thread-Topic: D2340: Support for Alpine platform from Annapurna Labs X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: MzFmODEzYTliMzhlZDlhOTEyM2NlYTg2YmJiIFVTcaA= Precedence: bulk X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-arm@freebsd.org X-Mailman-Version: 2.1.20 List-Id: "Porting FreeBSD to ARM processors." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 May 2015 15:45:37 -0000 andrew added a comment. Two points: 1. If there is any chance the vendor code will ever be updated it should be committed though the vendor area in subversion. 2. I think the pci driver isn't ready, can you create a new review for just this. INLINE COMMENTS sys/arm/annapurna/alpine/alpine_machdep_mp.c:89 This needs a newline: boolean_t alpine_validate_cpu(...) Should it be static? sys/arm/annapurna/alpine/alpine_machdep_mp.c:174 Missing space, should be `base = 0;`, and the same for size. sys/arm/annapurna/alpine/alpine_machdep_mp.c:176 if (pbase == NULL || psize == NULL) sys/arm/annapurna/alpine/alpine_machdep_mp.c:277 This has the same style issues as alpine_get_nb_base. sys/boot/fdt/dts/arm/annapurna-alpine.dts:2 So they will be released in Linux 4.1. We should try to reduce the difference between what we add and the 4.1-rc3 files. REVISION DETAIL https://reviews.freebsd.org/D2340 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: jpa-semihalf.com, ian, andrew, imp Cc: emaste, meloun-miracle-cz, onwahe-gmail-com, freebsd-arm