From owner-freebsd-current@freebsd.org Sun Aug 5 10:43:52 2018 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D28F310724A7 for ; Sun, 5 Aug 2018 10:43:52 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 25A3A8B1FA; Sun, 5 Aug 2018 10:43:52 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from tom.home (kib@localhost [127.0.0.1]) by kib.kiev.ua (8.15.2/8.15.2) with ESMTPS id w75AhfQW026384 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Sun, 5 Aug 2018 13:43:44 +0300 (EEST) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua w75AhfQW026384 Received: (from kostik@localhost) by tom.home (8.15.2/8.15.2/Submit) id w75AhfbR026383; Sun, 5 Aug 2018 13:43:41 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Sun, 5 Aug 2018 13:43:41 +0300 From: Konstantin Belousov To: Kyle Evans Cc: freebsd-current Current Subject: Re: panic: mutex pmap not owned at ... efirt_machdep.c:255 Message-ID: <20180805104341.GX6049@kib.kiev.ua> References: <20180804083720.GJ6049@kib.kiev.ua> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on tom.home X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 05 Aug 2018 10:43:53 -0000 On Sat, Aug 04, 2018 at 09:46:39PM -0500, Kyle Evans wrote: > On Sat, Aug 4, 2018 at 3:37 AM, Konstantin Belousov wrote: > > On Fri, Aug 03, 2018 at 11:27:02PM -0500, Kyle Evans wrote: > >> On Fri, Aug 3, 2018 at 10:10 PM, Eitan Adler wrote: > >> > Hi all, > >> > > >> > After installing the latest current kernel I get the following panic: > >> > > >> > panic: mutex pmap not owned at ... efirt_machdep.c:255 > >> > cpuid =3 > >> > time = 1 > >> > ... > >> > mtx_assert() > >> > efi_arch_enter() > >> > efirt_modevents() > >> > module_register_init() > >> > mi_startup() > >> > btext() > >> > > >> > >> This seems odd- pmap lock is acquired at [1], then asserted shortly > >> later at [2]... I avoid some of this stuff as well as I can, but is it > >> actually possible for PCPU_GET(...) acquired curpmap to not match > >> curthread->td_proc->p_vmspace->vm_pmap in this context? > >> > >> [1] https://svnweb.freebsd.org/base/head/sys/dev/efidev/efirt.c?view=markup#l260 > >> [2] https://svnweb.freebsd.org/base/head/sys/amd64/amd64/efirt_machdep.c?view=markup#l254 > > There could be that curpcpu not yet synced with proc0 pmap. It could be > > fixed. > > > > He now gets a little further, but ends up with the same panic due to > efirtc_probe trying to get time to verify the rtc's actually > implemented. What kind of approach must we take to ensure curcpu is > synced? It does not panic for me, when I load efirt.ko from the loader prompt. Anyway, try this diff --git a/sys/amd64/amd64/pmap.c b/sys/amd64/amd64/pmap.c index 572b2197453..f84f56b98e2 100644 --- a/sys/amd64/amd64/pmap.c +++ b/sys/amd64/amd64/pmap.c @@ -2655,7 +2655,7 @@ pmap_pinit0(pmap_t pmap) __pcpu[i].pc_ucr3 = PMAP_NO_CR3; } } - PCPU_SET(curpmap, kernel_pmap); + PCPU_SET(curpmap, pmap); pmap_activate(curthread); CPU_FILL(&kernel_pmap->pm_active); }