From owner-freebsd-stable@FreeBSD.ORG  Fri Nov 20 23:21:20 2009
Return-Path: <owner-freebsd-stable@FreeBSD.ORG>
Delivered-To: freebsd-stable@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 2FF0D1065670
	for <freebsd-stable@freebsd.org>; Fri, 20 Nov 2009 23:21:20 +0000 (UTC)
	(envelope-from linimon@lonesome.com)
Received: from mail.soaustin.net (lefty.soaustin.net [66.135.55.46])
	by mx1.freebsd.org (Postfix) with ESMTP id 11ABE8FC14
	for <freebsd-stable@freebsd.org>; Fri, 20 Nov 2009 23:21:19 +0000 (UTC)
Received: by mail.soaustin.net (Postfix, from userid 502)
	id 0DAC68C080; Fri, 20 Nov 2009 17:05:26 -0600 (CST)
Date: Fri, 20 Nov 2009 17:05:26 -0600
From: Mark Linimon <linimon@lonesome.com>
To: Jeremy Chadwick <freebsd@jdc.parodius.com>
Message-ID: <20091120230525.GA11504@lonesome.com>
References: <4B02B7D4.7020502@madhaus.cns.utoronto.ca>
	<4B06E274.3090207@madhaus.cns.utoronto.ca>
	<20091120194613.GA81572@icarus.home.lan>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20091120194613.GA81572@icarus.home.lan>
User-Agent: Mutt/1.5.18 (2008-05-17)
Cc: freebsd-stable@freebsd.org
Subject: Re: NSIS compile failed on FreeBSD 7.2
X-BeenThere: freebsd-stable@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Production branch of FreeBSD source code <freebsd-stable.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-stable>, 
	<mailto:freebsd-stable-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-stable>
List-Post: <mailto:freebsd-stable@freebsd.org>
List-Help: <mailto:freebsd-stable-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-stable>,
	<mailto:freebsd-stable-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 20 Nov 2009 23:21:20 -0000

On Fri, Nov 20, 2009 at 11:46:13AM -0800, Jeremy Chadwick wrote:
> If that's indeed the case, then the port Makefile needs to be modified
> to reject building on any architectures other than i386.  This should
> suffice:
> 
> ONLY_FOR_ARCHS=	i386

There's a (fine?) distinction between the usage of IGNORE (which
*_FOR_ARCHS drives) and BROKEN.  The former is more of a statement
of "it will never work"; the latter is more of a statement of "it
doesn't work right now."

So, in my own patches for e.g. sparc64, I use

.if ${ARCH} == "sparc64"
BROKEN=         Does not compile on sparc64
.endif

unless the port bails out of config with "arch not supported", or it's
clearly i386-hardware-related, or something like that.

I recognize that this may be a matter of personal taste.

mcl