From owner-svn-src-all@freebsd.org Wed Oct 2 07:53:07 2019 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id DF8F01256DD; Wed, 2 Oct 2019 07:53:07 +0000 (UTC) (envelope-from royger@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46jpKH5dMWz3yFs; Wed, 2 Oct 2019 07:53:07 +0000 (UTC) (envelope-from royger@FreeBSD.org) Received: from localhost (unknown [212.230.157.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: royger) by smtp.freebsd.org (Postfix) with ESMTPSA id 3E7418BF9; Wed, 2 Oct 2019 07:53:07 +0000 (UTC) (envelope-from royger@FreeBSD.org) Date: Wed, 2 Oct 2019 09:53:02 +0200 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Ravi Pokala Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r352925 - head/sys/dev/xen/control Message-ID: <20191002075302.caak27hnk5vlpqgr@Air-de-Roger> References: <201910010821.x918LfOg005983@repo.freebsd.org> <5E0C7E54-2657-4E70-8A18-84C4EE29D4FA@panasas.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5E0C7E54-2657-4E70-8A18-84C4EE29D4FA@panasas.com> User-Agent: NeoMutt/20180716 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Oct 2019 07:53:07 -0000 On Tue, Oct 01, 2019 at 06:42:14PM -0700, Ravi Pokala wrote: > Hi Roger, > > If I'm understanding this diff correctly, all of (poweroff, reboot, suspend) will use the common string "shutdown", rather than an event-specific string. Is that what we want? I think there's some misunderstanding here. All power control events use the same xenstore node (~/control/shutdown), but the command read from it is different depending on the requested action (poweroff, reboot, halt...). See [0] for a slightly more detailed description of the xenstore node. Note that this commit doesn't change any of this logic, it just clears the contents of ~/control/shutdown (by writing "") so the toolstack knows FreeBSD has acknowledged the request and it's processing it. Roger. [0] http://xenbits.xen.org/docs/4.12-testing/misc/xenstore-paths.html#platform-feature-and-control-paths