From owner-svn-ports-all@freebsd.org Mon Aug 24 09:45:39 2015 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 264D09C1363; Mon, 24 Aug 2015 09:45:39 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by mx1.freebsd.org (Postfix) with ESMTP id 175D310C0; Mon, 24 Aug 2015 09:45:39 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 1033) id 168231F07; Mon, 24 Aug 2015 09:45:39 +0000 (UTC) Date: Mon, 24 Aug 2015 09:45:39 +0000 From: Alexey Dokuchaev To: Baptiste Daroussin Cc: Mathieu Arnold , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r395079 - in head/graphics: . mitsuba mitsuba/files Message-ID: <20150824094539.GA77434@FreeBSD.org> References: <201508230856.t7N8uwal009338@repo.freebsd.org> <96D957F8044D8B647B259802@atuin.in.mat.cc> <20150824070915.GA15244@FreeBSD.org> <20150824084807.GA93486@ivaldir.etoilebsd.net> <20150824090104.GB93486@ivaldir.etoilebsd.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150824090104.GB93486@ivaldir.etoilebsd.net> User-Agent: Mutt/1.5.23 (2014-03-12) X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 24 Aug 2015 09:45:39 -0000 On Mon, Aug 24, 2015 at 11:01:04AM +0200, Baptiste Daroussin wrote: > On Mon, Aug 24, 2015 at 10:48:07AM +0200, Baptiste Daroussin wrote: > > On Mon, Aug 24, 2015 at 07:09:15AM +0000, Alexey Dokuchaev wrote: > > > [...] > > > That said, OSVERSION < 900014 will not always be false. And why do you > > > want to be rude to our users and deliberately break things just because > > > we no longer promise that they will work? > > > > Even in that case, this is wrong anyway as you enforce GCC while should > > should require a modern compiler via compiler.mk. I've thought of Uses/compiler.mk, but eventually couldn't decide which compiler to ask for: the problem in my case was not with the code (so it is not like "port needs a compiler understanding C++0X/C++11/C++14", but the bugginess of GCC 4.2.1 itself. (Now that I'm reading through it again, compiler:openmp looks interesting). Or there's a way to require a modern compiler thish is not feature-based? > Btw that would even be nicer to only use compiler.mk feature as it will > give this port a chance to work on supported freebsd version on some > tiers-2 architecture which depends on gcc 4.2.1: mips, powerpc, sparc64, > etc. While your patch only gives a chance for it to work on unsupported > version :) Certainly, and usually I try to be careful about tiers-2. In this case, however, I'd have to find a way to de-SSE2'ize the code beforehand; it is on my list, but quite of low priority. ./danfe