Date: Mon, 28 Oct 2002 19:39:27 -0800 From: Juli Mallett <jmallett@FreeBSD.org> To: David O'Brien <obrien@FreeBSD.org>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.bin/make Makefile job.c nonints.h str.c var.c var.h var_modify.c Message-ID: <20021028193927.A67748@FreeBSD.org> In-Reply-To: <20021029032337.GB36927@dragon.nuxi.com>; from obrien@FreeBSD.org on Mon, Oct 28, 2002 at 07:23:37PM -0800 References: <200210282333.g9SNXvvt039931@repoman.freebsd.org> <20021029032337.GB36927@dragon.nuxi.com>
next in thread | previous in thread | raw e-mail | index | archive | help
* De: David O'Brien <obrien@FreeBSD.org> [ Data: 2002-10-28 ] [ Subjecte: Re: cvs commit: src/usr.bin/make Makefile job.c nonints.h str.c var.c var.h var_modify.c ] > On Mon, Oct 28, 2002 at 03:33:57PM -0800, Juli Mallett wrote: > > jmallett 2002/10/28 15:33:57 PST > > > > Modified files: > > usr.bin/make Makefile job.c nonints.h str.c var.c > > Added files: > > usr.bin/make var.h var_modify.c > > Log: > > Split var.c into var.c and var_modify.c and move all the modification funcs > > to var_modify.c, for readability. constify some low hanging fruit (string > > manipulation functions) and the upper layers appropriately. No longer use > > the private strstr(3) implementation, while changing string code. > > Are you willing to name this varmodifiers.c and organize it simular to > what OpenBSD has done? It would certainly help notice bugs fixed in > their code base. Or leave things as-is to make it easier to notice bugs > fixed in NetBSD? We don't need so much divergence in what once was a > 100% common code base. Looking at differences in make(1) is haphazard, unles you do it on a per function basis, and follow the codepaths. Otherwise you get bitten by lots of sublte differences. But anyway, I'm just doing things to make it easier to find and fix the bugs in our make(1), and whatnot. I'm against pretending to be similar to OpenBSD make(1) when we cannot be all the way similar, and I'm against trying to keep the differences small to NetBSD in ways which make it harder for us to maintain our own code, or which make it harder to seperate our differences, which are fairly important, as noted by the fact that NetBSD make(1) still can't build our world. Everyone's making style, spelling, local, functional, feature, whatever changes based on what they need, just like with the kernel, and most utilities, and for now, until we can build everything with NetBSD stuff or OpenBSD stuff, and do so in a sane way, I'm only interested in trying my damnedest to fix our make(1) and add things we could benefit from. -- Juli Mallett <jmallett@FreeBSD.org> | FreeBSD: The Power To Serve Will break world for fulltime employment. | finger jmallett@FreeBSD.org http://people.FreeBSD.org/~jmallett/ | Support my FreeBSD hacking! To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20021028193927.A67748>