From owner-freebsd-current@FreeBSD.ORG Sun Jul 5 14:29:18 2009 Return-Path: Delivered-To: current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5366E1065672; Sun, 5 Jul 2009 14:29:18 +0000 (UTC) (envelope-from lwindschuh@googlemail.com) Received: from mail-pz0-f193.google.com (mail-pz0-f193.google.com [209.85.222.193]) by mx1.freebsd.org (Postfix) with ESMTP id E56488FC12; Sun, 5 Jul 2009 14:29:17 +0000 (UTC) (envelope-from lwindschuh@googlemail.com) Received: by pzk31 with SMTP id 31so1658243pzk.3 for ; Sun, 05 Jul 2009 07:29:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:content-type :content-transfer-encoding; bh=6aH2MAGquB2i66jKpZIpFGuv/u7CaYFBXs6fQy7WK5U=; b=nIDfrNQ0PnoRDQ9EAsF2LGD7zC3DkHI7BnyWX2B0nDemp/ZxoDwBfd4dK0tDNpC9Kq 9aNbCLZQVaRuTGrRb6SG03WsGCDFjpN6ncyWlD3WTqkTSTlEU2JXBI1NHIRgWJNJjmp4 A5nr575F7jl/XQMwS1gnJsqFaRZ8TFn5JrrSg= DomainKey-Signature: a=rsa-sha1; c=nofws; d=googlemail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type:content-transfer-encoding; b=jDzNPBSNbDDRUdVnUcHuACcpGUqyl9IJglqieniM+zA9ljUPLqbD0+KOd8uf5Mrw7u BytQ9xIKY5FN2TXJYaOF0y4GNEvhruqOvsVllceJwbZiBihhroanianfkxrL4hTuJbXS O+xf3uUppOsaB4UXcU/PUlZDqAPY+8NBidjSs= MIME-Version: 1.0 Received: by 10.142.164.10 with SMTP id m10mr1042706wfe.140.1246804157660; Sun, 05 Jul 2009 07:29:17 -0700 (PDT) In-Reply-To: <4A5053A8.2060902@FreeBSD.org> References: <4A4517BE.9040504@FreeBSD.org> <4A4FEBBC.30203@omnilan.de> <4A5053A8.2060902@FreeBSD.org> Date: Sun, 5 Jul 2009 16:29:17 +0200 Message-ID: <90a5caac0907050729k4b24f2eaj64f7d752bddff1ea@mail.gmail.com> From: Lucius Windschuh To: Alexander Motin , current@freebsd.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Subject: Re: RFC: ATA to CAM integration patch (and gjournaled previuos nodes) X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 05 Jul 2009 14:29:18 -0000 Hi Alexander. 2009/7/5 Alexander Motin : > It's never late. I have just uploaded fresh patch: > http://people.freebsd.org/~mav/cam-ata.20090704.patch "make buildworld" with this patch stops in my configuration with: (cd /usr/src/rescue/rescue/../../usr.sbin/chown && /usr/obj/usr/src/make.i386/make -DRESCUE CRUNCH_CFLAGS=-DRESCUE DIRPRFX=rescue/rescue/chown/ depend && /usr/obj/usr/src/make.i386/make -DRESCUE CRUNCH_CFLAGS=-DRESCUE DIRPRFX=rescue/rescue/chown/ chown.o) `chown.o' is up to date. cc -static -o rescue rescue.o cat.lo chflags.lo chio.lo chmod.lo cp.lo date.lo dd.lo df.lo echo.lo ed.lo expr.lo getfacl.lo hostname.lo kenv.lo kill.lo ln.lo ls.lo mkdir.lo mv.lo pkill.lo ps.lo pwd.lo realpath.lo rm.lo rmdir.lo setfacl.lo sh.lo stty.lo sync.lo test.lo rcp.lo csh.lo atacontrol.lo badsect.lo camcontrol.lo ccdconfig.lo clri.lo devfs.lo dmesg.lo dump.lo dumpfs.lo dumpon.lo fsck.lo fsck_ffs.lo fsck_msdosfs.lo fsdb.lo fsirand.lo gbde.lo geom.lo ifconfig.lo init.lo kldconfig.lo kldload.lo kldstat.lo kldunload.lo ldconfig.lo md5.lo mdconfig.lo mdmfs.lo mknod.lo mount.lo mount_cd9660.lo mount_msdosfs.lo mount_nfs.lo mount_ntfs.lo mount_nullfs.lo mount_udf.lo mount_unionfs.lo newfs.lo newfs_msdos.lo nos-tun.lo ping.lo reboot.lo restore.lo rcorder.lo route.lo routed.lo rtquery.lo rtsol.lo savecore.lo spppcontrol.lo swapon.lo sysctl.lo tunefs.lo umount.lo atmconfig.lo ping6.lo ipf.lo zfs.lo zpool.lo bsdlabel.lo sconfig.lo fdisk.lo dhclient.lo head.lo mt.lo sed.lo tail.lo tee.lo gzip.lo bzip2.lo tar.lo vi.lo id.lo chroot.lo chown.lo /usr/obj/usr/src/rescue/rescue/../librescue/exec.o /usr/obj/usr/src/rescue/rescue/../librescue/getusershell.o /usr/obj/usr/src/rescue/rescue/../librescue/login_class.o /usr/obj/usr/src/rescue/rescue/../librescue/popen.o /usr/obj/usr/src/rescue/rescue/../librescue/rcmdsh.o /usr/obj/usr/src/rescue/rescue/../librescue/sysctl.o /usr/obj/usr/src/rescue/rescue/../librescue/system.o -lcrypt -ledit -lkvm -ll -ltermcap -lutil -lalias -lcam -lcurses -ldevstat -lipsec -lipx -lzfs -lnvpair -luutil -lavl -lgeom -lbsdxml -ljail -lkiconv -lmd -lreadline -lsbuf -lufs -lz -lbz2 -larchive -lcrypto -lm /usr/obj/usr/src/tmp/usr/lib/libcam.a(ata_all.o)(.text+0x263): In function `ata_max_mode': : undefined reference to `min' *** Error code 1 Stop in /usr/obj/usr/src/rescue/rescue. *** Error code 1 Stop in /usr/src/rescue/rescue. *** Error code 1 Stop in /usr/src/rescue. *** Error code 1 Stop in /usr/src. *** Error code 1 Simply adding #ifndef min #define min(a,b) (((a)<(b))?(a):(b)) #endif in ata_all.c helps, obviously. Regards, Lucius