From owner-svn-src-all@freebsd.org  Sun Apr  8 02:39:34 2018
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8B1CDF9B31F;
 Sun,  8 Apr 2018 02:39:34 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "freefall.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 3F5916C1A4;
 Sun,  8 Apr 2018 02:39:34 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: by freefall.freebsd.org (Postfix, from userid 1033)
 id 1E9BBD403; Sun,  8 Apr 2018 02:39:34 +0000 (UTC)
Date: Sun, 8 Apr 2018 02:39:34 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Conrad Meyer <cem@freebsd.org>
Cc: Roger Pau Monn?? <royger@freebsd.org>, svn-src-head@freebsd.org,
 svn-src-all@freebsd.org, src-committers <src-committers@freebsd.org>
Subject: Re: svn commit: r332092 - in head/sys: amd64/amd64 sys x86/x86
Message-ID: <20180408023934.GA85042@FreeBSD.org>
References: <201804061120.w36BK6s6074635@repo.freebsd.org>
 <CAG6CVpV8Ue-t--+MMS+11x_=LjgWbQiAq2KGzOEdiGPpxQ+PhQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAG6CVpV8Ue-t--+MMS+11x_=LjgWbQiAq2KGzOEdiGPpxQ+PhQ@mail.gmail.com>
User-Agent: Mutt/1.9.2 (2017-12-15)
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.25
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 08 Apr 2018 02:39:34 -0000

On Fri, Apr 06, 2018 at 07:14:42AM -0700, Conrad Meyer wrote:
> I like something like this for clarity.  But I don't see any reason
> for these function-like macros instead of the more general definition
> of an SI prefix constant multiple.  A multiple works with numeric
> literals and variables alike.  Something like:

As Bruce had said, 1G is normally written as 1024 * 1024 * 1024 and this
is clearer than 1 << 30.  Macros/functions like these are evil and bring
more problems than they solve (again, as Bruce had explained).  GiB name
is also ugly (correct spelling is GB).  IMHO the whole thing should just
be removed.

./danfe