From owner-freebsd-multimedia@FreeBSD.ORG Mon Jul 18 21:18:20 2011 Return-Path: Delivered-To: freebsd-multimedia@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D39C91065674 for ; Mon, 18 Jul 2011 21:18:20 +0000 (UTC) (envelope-from itetcu@FreeBSD.org) Received: from worf.ds9.tecnik93.com (worf.ds9.tecnik93.com [81.196.207.130]) by mx1.freebsd.org (Postfix) with ESMTP id 882538FC1C for ; Mon, 18 Jul 2011 21:18:20 +0000 (UTC) Received: from it.buh.tecnik93.com (unknown [188.26.251.43]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by worf.ds9.tecnik93.com (Postfix) with ESMTPSA id EECCA22C5430; Tue, 19 Jul 2011 00:18:18 +0300 (EEST) Date: Tue, 19 Jul 2011 00:18:18 +0300 From: Ion-Mihai Tetcu To: Alexander Leidinger Message-ID: <20110719001818.6a13084d@it.buh.tecnik93.com> In-Reply-To: <20110718223734.00003b64@unknown> References: <20110714205415.GA3304@triton8.kn-bremen.de> <20110715123002.363272dtl9b48dka@webmail.leidinger.net> <20110715191003.GA60074@triton8.kn-bremen.de> <20110718223734.00003b64@unknown> X-Mailer: Claws Mail 3.7.9 (GTK+ 2.22.1; amd64-portbld-freebsd8.2) Mime-Version: 1.0 Content-Type: multipart/signed; micalg=PGP-SHA1; boundary="Sig_/COH2KmXPwzzldnFZnUkY8di"; protocol="application/pgp-signature" Cc: freebsd-multimedia@FreeBSD.org, Juergen Lock Subject: Re: Fixing skype multimedia/linux_v4l2wrapper dependency on 8 X-BeenThere: freebsd-multimedia@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Multimedia discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Jul 2011 21:18:20 -0000 --Sig_/COH2KmXPwzzldnFZnUkY8di Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Mon, 18 Jul 2011 22:37:34 +0200 Alexander Leidinger wrote: > > > > +.else > > > > +.if ${OSVERSION} =3D=3D 900036 || ${OSVERSION} =3D=3D 802508 > > > > +LINUX_V4L2_INBASE!=3D ($(SYSCTL) -n > > > > kern.features.linuxulator_v4l2 =20 > > > > 2>/dev/null || true) =20 > > >=20 > > > Here you say it can only be used *if it is loaded or compiled in*. > > > =20 > > Yeah it is a crude check which will fail if linux.ko isn't loaded > > (or statically compiled in.) I only added this because you didn't > > bump __FreeBSD_version so these OSVERSIONs can either have it or > > not. But since it's the best I could come up in with this situation > > and the only harm done would be the linux_v4l2wrapper.ko would get > > installed when it is not needed I think it's justified. (The kld > > probably could even be loaded when the code is in the kernel already > > and skype would still work... Hmm or should we just depend on that > > and on these OSVERSIONs install the kld unconditionally?) =20 >=20 > It depends on what you want to achieve. IMO just wait for complains > that it does not work. If nobody complains, it may be that it is not > necessary to invest the time and energy to change this. As there are > more places which depend upon linux-stuff being in memory, I would > assume that most people which want to install skype already have it in > memory at the time when the check is run. had about 4 people complain about .... all of which didn't had newer enough OSVERSION or did not bother to setup alsa right ... not sure if it's worth the trouble spending time on this ... --=20 IOnut - Un^d^dregistered ;) FreeBSD "user" "Intellectual Property" is nowhere near as valuable as "Intellect" FreeBSD committer -> itetcu@FreeBSD.org, PGP Key ID 057E9F8B493A297B --Sig_/COH2KmXPwzzldnFZnUkY8di Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.17 (FreeBSD) iEYEARECAAYFAk4koxoACgkQJ7GIuiH/oeWd7gCgsaQQ/n24WWRxTxqxEFqmmY03 uXYAoKtS0aKjilw6yheip9VkdRq+Dw2z =txr5 -----END PGP SIGNATURE----- --Sig_/COH2KmXPwzzldnFZnUkY8di--