From owner-freebsd-current@FreeBSD.ORG Fri Nov 6 15:51:08 2009 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4682E1065670; Fri, 6 Nov 2009 15:51:08 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id 176858FC1A; Fri, 6 Nov 2009 15:51:08 +0000 (UTC) Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net [66.111.2.69]) by cyrus.watson.org (Postfix) with ESMTPSA id BDBB146B0D; Fri, 6 Nov 2009 10:51:07 -0500 (EST) Received: from jhbbsd.hudson-trading.com (unknown [209.249.190.8]) by bigwig.baldwin.cx (Postfix) with ESMTPA id 051918A01F; Fri, 6 Nov 2009 10:51:04 -0500 (EST) From: John Baldwin To: Attilio Rao Date: Fri, 6 Nov 2009 10:50:50 -0500 User-Agent: KMail/1.9.7 References: <3bbf2fe10911060712y46684f76sefe195a62083c15@mail.gmail.com> In-Reply-To: <3bbf2fe10911060712y46684f76sefe195a62083c15@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200911061050.50873.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.0.1 (bigwig.baldwin.cx); Fri, 06 Nov 2009 10:51:04 -0500 (EST) X-Virus-Scanned: clamav-milter 0.95.1 at bigwig.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-2.4 required=4.2 tests=AWL,BAYES_00,RDNS_NONE, SUBJECT_FUZZY_TION autolearn=no version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on bigwig.baldwin.cx Cc: freebsd-current@freebsd.org, Ed Maste Subject: Re: [PATCH] Boot-time entering prompt by typing "123" sequence rather than any button X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Nov 2009 15:51:08 -0000 On Friday 06 November 2009 10:12:59 am Attilio Rao wrote: > This patch adds the possibility to enter the prompt at boot time by > typing the sequence of buttons "123" rather than a single button: > http://www.freebsd.org/~attilio/Sandvine/STABLE_8/boot123/boot123.diff > > This is useful in the cases where a serial console is likely going to > be used which can carry on spourious character, leding to the prompt > erroneously. > This option is wrappered into the BOOT_PROMPT_123 option, in order to > maintain the current POLA. > This patch has been contributed back by Sandvine Incorporated. > Please review. This seems a bit hackish, but the patch is fine on technical grounds. On machines where I have a serial console I tend to put "-Dh" in /boot.config (so I can choose an alternate loader if need be) and in that case boot2 would eat the extra input and pause during the boot process (I've had this happen occasionally). This patch wouldn't help with that case. Another suggestion made on IRC was to simply drain input at the start of boot2 or loader to avoid accepting early spurious input. This won't help if you are dealing with noisy serial lines that are just spewing random garbage during the boot process however. -- John Baldwin