From owner-cvs-all Wed Feb 21 12:22:21 2001 Delivered-To: cvs-all@freebsd.org Received: from csunb0.leeds.ac.uk (csunb0.leeds.ac.uk [129.11.144.2]) by hub.freebsd.org (Postfix) with SMTP id 08E2537B401; Wed, 21 Feb 2001 12:22:17 -0800 (PST) (envelope-from csxbcs@comp.leeds.ac.uk) Received: from cslin.leeds.ac.uk (csunc0.leeds.ac.uk [129.11.144.3]) by csunb0.leeds.ac.uk (8.6.12/8.6.12) with ESMTP id UAA09684; Wed, 21 Feb 2001 20:16:16 GMT Received: from cslin006.leeds.ac.uk (cslin006 [129.11.146.6]) by cslin.leeds.ac.uk (8.9.3+Sun/) with ESMTP id UAA15711; Wed, 21 Feb 2001 20:16:15 GMT Received: (from csxbcs@localhost) by cslin006.leeds.ac.uk (8.11.0/8.11.2) id f1LKGGQ25552; Wed, 21 Feb 2001 20:16:16 GMT Date: Wed, 21 Feb 2001 20:16:16 +0000 From: Ben Smithurst To: Poul-Henning Kamp Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/share/man/man9 style.9 Message-ID: <20010221201615.A25231@comp.leeds.ac.uk> References: <200102211210.f1LCAKN41997@freefall.freebsd.org> <1166.982760630@critter> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <1166.982760630@critter> Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG Poul-Henning Kamp wrote: > Better, and more readable: > > error = function(a1, a2); > if (error != 0) Well that's a matter of opinion, but I suppose it's easily changed. :-) I figured there's enough use of 'if ((var = func()) != 0)' in FreeBSD that everyone knows exactly what it does and yours isn't really any more readable. But it can easily be changed if people generally agree with you. -- Ben Smithurst / csxbcs@comp.leeds.ac.uk / ben@FreeBSD.org To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message