From owner-cvs-src@FreeBSD.ORG Thu May 3 13:40:54 2007 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 39BA716A401; Thu, 3 May 2007 13:40:54 +0000 (UTC) (envelope-from mi+metlife@aldan.algebra.com) Received: from bonkers.video-collage.com (static-151-204-231-237.bos.east.verizon.net [151.204.231.237]) by mx1.freebsd.org (Postfix) with ESMTP id D114313C45B; Thu, 3 May 2007 13:40:53 +0000 (UTC) (envelope-from mi+metlife@aldan.algebra.com) Received: from [127.0.0.1] (localhost [127.0.0.1]) by bonkers.video-collage.com (8.14.1/8.14.1) with ESMTP id l43DTrtU048612; Thu, 3 May 2007 09:29:53 -0400 (EDT) (envelope-from mi+metlife@aldan.algebra.com) Message-ID: <4639E3D0.1050208@aldan.algebra.com> Date: Thu, 03 May 2007 09:29:52 -0400 From: "Mikhail T." User-Agent: Thunderbird 2.0.0.0 (Windows/20070326) MIME-Version: 1.0 To: Kris Kennaway , Rong-en Fan , kientzle@freebsd.org, portmgr@freebsd.org, src-committers@freebsd.org, cvs-src@freebsd.org, cvs-all@freebsd.org References: <200703151011.l2FABc9Z013002@repoman.freebsd.org> <6eb82e0705022031g3b959688k5fb63b6e441a6d86@mail.gmail.com> <4639663D.1020308@freebsd.org> <20070503062438.GA50698@xor.obsecurity.org> In-Reply-To: <20070503062438.GA50698@xor.obsecurity.org> Content-Type: text/plain; charset=KOI8-U; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Scanned: ClamAV 0.88.7/3200/Thu May 3 07:42:47 2007 on bonkers.video-collage.com X-Virus-Status: Clean Cc: Subject: Re: cvs commit: src/usr.bin/tar write.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 May 2007 13:40:54 -0000 Kris Kennaway wrote: > On Wed, May 02, 2007 at 09:34:05PM -0700, Colin Percival wrote: > >> Rong-en Fan wrote: >> >>> On 3/15/07, Colin Percival wrote: >>> >>>> Modified files: >>>> usr.bin/tar write.c >>>> Log: >>>> Don't consider an lstat(2) failure to be an error (in the sense of >>>> affecting the return value from bsdtar) [...] >>>> >>> This commit makes 'make package' successfully even if the plist is >>> wrong, i.e. it contains ``ghost'' files. Basically, >>> >>> $ tar zcvf a.tgz /aaa >>> tar: /aaa: Cannot stat: No such file or directory >>> >>> It returns 0, so make package will be considered successful. >>> >> I've fixed this in revision 1.62. >> >> Colin Percival >> > > Thanks, I think mi@ ran into this recently too. > So, this is fixed now? I guess, the fears, that fixing it would require fixing multitude of ports, were somewhat ungrounded. -mi