From owner-freebsd-current@FreeBSD.ORG  Thu Jul 14 15:37:07 2005
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
X-Original-To: freebsd-current@freebsd.org
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id F305C16A41C
	for <freebsd-current@freebsd.org>; Thu, 14 Jul 2005 15:37:06 +0000 (GMT)
	(envelope-from nike_d@cytexbg.com)
Received: from office.suresupport.com (office.suresupport.com [213.145.98.15])
	by mx1.FreeBSD.org (Postfix) with SMTP id 0D6A043D4C
	for <freebsd-current@freebsd.org>; Thu, 14 Jul 2005 15:37:04 +0000 (GMT)
	(envelope-from nike_d@cytexbg.com)
Received: (qmail 78104 invoked by uid 1026); 14 Jul 2005 15:38:31 -0000
Received: from 213.145.98.14 by office.suresupport.com (envelope-from
	<nike_d@cytexbg.com>, uid 1004) with qmail-scanner-1.23 
	(f-prot: 4.4.2/3.14.11.  Clear:RC:1(213.145.98.14):. 
	Processed in 0.128463 secs); 14 Jul 2005 15:38:31 -0000
Received: from unknown (HELO 14.98.145.213.in-addr.arpa) (213.145.98.14)
	by office.suresupport.com with SMTP; 14 Jul 2005 15:38:31 -0000
From: Niki Denev <nike_d@cytexbg.com>
To: freebsd-current@freebsd.org
Date: Thu, 14 Jul 2005 18:37:02 +0300
User-Agent: KMail/1.8
References: <200507121026.16664.nike_d@cytexbg.com>
	<20050713210811.GA60866@heff.fud.org.nz>
In-Reply-To: <20050713210811.GA60866@heff.fud.org.nz>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200507141837.02609.nike_d@cytexbg.com>
Subject: Re: add a few informative printfs to if_bridge.c?
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 14 Jul 2005 15:37:07 -0000

On Thursday 14 July 2005 00:08, Andrew Thompson wrote:
> On Tue, Jul 12, 2005 at 10:26:16AM +0300, Niki Denev wrote:
> > Hello all,
> >
> > So, i have a proposition to add some informative printfs to if_bridge
> > code, because returning "Invalid argument" is not so self explanatory,
> > especially in the wrong MTU case. I think that most of the returns in
> > bridge_ioctl_add(), could benefit from additional printf with more
> > information.
> > What do you think?
>
> Ive added a message for the incorrect MTU case and also relaxed the
> requirements a little. The bridge will take the MTU of the first member
> interface rather than being hardcoded at 1500, all members are still
> required to have the exact same MTU.
>
>
> cheers,
>
> Andrew

Thanks!

--niki