From owner-freebsd-bugs Fri Jan 12 15:23: 5 2001 Delivered-To: freebsd-bugs@freebsd.org Received: from wantadilla.lemis.com (wantadilla.lemis.com [192.109.197.80]) by hub.freebsd.org (Postfix) with ESMTP id D0F3037B400 for ; Fri, 12 Jan 2001 15:22:47 -0800 (PST) Received: by wantadilla.lemis.com (Postfix, from userid 1004) id 88E8A6ABFF; Sat, 13 Jan 2001 09:52:45 +1030 (CST) Date: Sat, 13 Jan 2001 09:52:45 +1030 From: Greg Lehey To: Samuel Tardieu Cc: freebsd-bugs@FreeBSD.org Subject: Re: bin/24271: dumpon should check its argument more Message-ID: <20010113095245.A66238@wantadilla.lemis.com> References: <200101121610.f0CGA7a52473@freefall.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <200101121610.f0CGA7a52473@freefall.freebsd.org>; from sam@inf.enst.fr on Fri, Jan 12, 2001 at 08:10:07AM -0800 Organization: LEMIS, PO Box 460, Echunga SA 5153, Australia Phone: +61-8-8388-8286 Fax: +61-8-8388-8725 Mobile: +61-418-838-708 WWW-Home-Page: http://www.lemis.com/~grog X-PGP-Fingerprint: 6B 7B C3 8C 61 CD 54 AF 13 24 52 F8 6D A4 95 EF Sender: owner-freebsd-bugs@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org On Friday, 12 January 2001 at 8:10:07 -0800, Samuel Tardieu wrote: > On Fri, 12 Jan 2001 16:48:57 +0100, Samuel Tardieu wrote: > On 12/01, Bruce Evans wrote: >> On Fri, 12 Jan 2001 sam@inf.enst.fr wrote: >> >>>> Description: >>> dumpon should check that the argument is not a disk slice, or should >>> require a flag (-f?) in this case. It would prevent bad crashes :/ >> >> This is a feature. dumpon (like swapon and newfs) should work on any disk >> device, including the whole disk. It currently only works on disk devices >> whose containing slice is labeled, so it can only be misused to clobber >> BSD slices and not OtherOS slices (this is a bug :-). > > I would recommend to add a "-f" option anyway. It is way too easy to set > (as I did yesterday) "dumpdev=/dev/ad0s2" in your rc.conf and be very > surprised after a crash. If you really want to do this, you could do it > with a "dumpon_flags=-f". Agreed. There may be reasons to accept that you want to use an entire slice for your dump device, though I can't think of a convincing one, but it certainly shouldn't be the default. Greg -- Finger grog@lemis.com for PGP public key See complete headers for address and phone numbers To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message