From owner-cvs-src@FreeBSD.ORG Thu Apr 24 22:48:34 2008 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D4F001065674; Thu, 24 Apr 2008 22:48:34 +0000 (UTC) (envelope-from marius@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id D79A08FC18; Thu, 24 Apr 2008 22:48:34 +0000 (UTC) (envelope-from marius@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id m3OMmYjA042555; Thu, 24 Apr 2008 22:48:34 GMT (envelope-from marius@repoman.freebsd.org) Received: (from marius@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id m3OMmYar042554; Thu, 24 Apr 2008 22:48:34 GMT (envelope-from marius) Message-Id: <200804242248.m3OMmYar042554@repoman.freebsd.org> From: Marius Strobl Date: Thu, 24 Apr 2008 22:48:34 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/dev/sym sym_hipd.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Apr 2008 22:48:34 -0000 marius 2008-04-24 22:48:34 UTC FreeBSD src repository Modified files: sys/dev/sym sym_hipd.c Log: - Use bus_{read,write}_*(9) instead of bus_space_{read,write}_*(9) in order to get rid of bus space handle and tag in struct sym_hcb. - Remove unused members related to bus addresses in struct sym_hcb. - sym(4) takes care of allocating an instance of struct sym_hcb itself so don't let newbus allocate it as an unused softc also. - Add basic MPSAFE locking. This includes changing the sym(4) CCBs to be allocated up-front instead of on demand as needed. Besides making these allocations more likely to succeed, this also solves the problem of calling bus_dmamap_create(9) with the SIM mutex held. Reviewed by: scottl MFC after: 1 month Revision Changes Path 1.69 +157 -120 src/sys/dev/sym/sym_hipd.c