From owner-svn-src-stable-11@freebsd.org Sun Feb 11 07:01:49 2018 Return-Path: Delivered-To: svn-src-stable-11@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 83943F1C3F8; Sun, 11 Feb 2018 07:01:49 +0000 (UTC) (envelope-from antoine.brodin.freebsd@gmail.com) Received: from mail-io0-x22e.google.com (mail-io0-x22e.google.com [IPv6:2607:f8b0:4001:c06::22e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 0EFD26804D; Sun, 11 Feb 2018 07:01:49 +0000 (UTC) (envelope-from antoine.brodin.freebsd@gmail.com) Received: by mail-io0-x22e.google.com with SMTP id l17so14166789ioc.3; Sat, 10 Feb 2018 23:01:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=4aGICFTftFpMQsyaRyQKGTf7Prk/XsUsTaV+72612s0=; b=RPKWlZqmjMxTLiBNV/rUhtdUiUnQz/TPepadBzXNZ72adVNC//vMVvYmRgiMG5Oa1u bdedYWwDrHAf0/rg61yhDVIqpahEp/Hl7txG5wY6eE7ZkvQa8V1pgmWsq88pFpgwQAck KXm/P41hhj++FG22+5asH4RXbyXpOKdEI4SSWU6S3MZcXy0s1Zh0wIAXa6jOznQ8aj6+ J4k0+F8KNfI3Fh/espMU00FaRWRkPUhosmyuTeWyv7ux3lnx59guhn6aAv0tATrZLtTN qMM+u3oFaUEhbcFGSmhv+jLg+PyWwgDeMTGDJsxXkplYtPetuGShm2s5OwGydOG5yikf jZDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=4aGICFTftFpMQsyaRyQKGTf7Prk/XsUsTaV+72612s0=; b=DHliQWOy7tZstjxKbfVJJ/mYhzQsSXKYp0nXkn5gmvksaLGzR0Q170EqkWYSo2s2+v SBYWwplgSVf8SWUXVU5dw5lzpdBSA7L/aGF3pakmEGqe33F3e9CvIWFgwOGdr4Iqbm+Z VrPPRGWkTnpX7ODyE6PYVsHGDlK44MWZzdhKyF78SNJGBTUew+boeIdzXsJJiN1nI9w3 scmTAqXR4o1l36yQ89SIdhKz8ST+mUWhJIIqac/1tC/9YIs5u+/D4s4FjcW4IpwgVPmz 1sYFxe7/5IeQTwx+wxtlOrRb3winNfxicDR4r3MVR0eIjcV3mYcT35itL2EoU9m9N4SD JSNA== X-Gm-Message-State: APf1xPDhCH9/XH8onHRX/5HVMFqW7kYPMnGHWe7TXm1LY+HX4Cpo5Q1h bl7Q3G4KhL6iuDbDD5Zj1MyEh9UbspO/ECg9lwUyCA== X-Google-Smtp-Source: AH8x227RJqh0PW2EhdJqjvYL3guCnoGwYY3E4pXR0hy7tqums0g6CURuT0Q7bJSUdeBhhL571KTw3KHEdcgmdqXcUao= X-Received: by 10.107.142.68 with SMTP id q65mr9067744iod.133.1518332508472; Sat, 10 Feb 2018 23:01:48 -0800 (PST) MIME-Version: 1.0 Sender: antoine.brodin.freebsd@gmail.com Received: by 10.107.143.86 with HTTP; Sat, 10 Feb 2018 23:01:48 -0800 (PST) In-Reply-To: <201802071506.w17F6s5l043163@repo.freebsd.org> References: <201802071506.w17F6s5l043163@repo.freebsd.org> From: Antoine Brodin Date: Sun, 11 Feb 2018 08:01:48 +0100 X-Google-Sender-Auth: sc7kxLvlcqykSPCqpCxUesU0PVE Message-ID: Subject: Re: svn commit: r328973 - in stable/11: include sys/sys To: Hans Petter Selasky Cc: src-committers , svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-11@freebsd.org, re Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-src-stable-11@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for only the 11-stable src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 11 Feb 2018 07:01:49 -0000 On Wed, Feb 7, 2018 at 4:06 PM, Hans Petter Selasky wrote: > Author: hselasky > Date: Wed Feb 7 15:06:54 2018 > New Revision: 328973 > URL: https://svnweb.freebsd.org/changeset/base/328973 > > Log: > MFC r328237: > Use the __alloc_size2 attribute where relevant. > > This follows the documented use in GCC. It is basically only relevant for > calloc(3), reallocarray(3) and mallocarray(9). > > NOTE: Without this change clang 5.0.1 can produce incorrect optimisation > code for static processing of data using the allocated object. For example > this has been seen compiling the mlx4 core module, which allocates a > fixed size array which is then sorted by a fixed order loop. The > optimised result, -O2, is incorrect unless this patch is in place. > > Suggested by: Mark Millard > Reference: https://docs.freebsd.org/cgi/mid.cgi?9DE674C6-EAA3-4E8A-906F-446E74D82FC4 > > Modified: > stable/11/include/stdlib.h > stable/11/sys/sys/malloc.h > Directory Properties: > stable/11/ (props changed) Hi, Please revert this change. Lots of ports that used to build fine on stable/11 are now failing. /usr/include/stdlib.h:93:7: error: expected function body after function declarator __alloc_size2(1, 2); Antoine (with hat: portmgr)