From owner-p4-projects@FreeBSD.ORG  Thu Jul  8 11:13:24 2010
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id BC93E1065678; Thu,  8 Jul 2010 11:13:24 +0000 (UTC)
Delivered-To: perforce@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 7B59F1065673;
	Thu,  8 Jul 2010 11:13:24 +0000 (UTC)
	(envelope-from alexandre@net.t-labs.tu-berlin.de)
Received: from mail.net.t-labs.tu-berlin.de (mail.net.t-labs.tu-berlin.de
	[130.149.220.252])
	by mx1.freebsd.org (Postfix) with ESMTP id 3A2C78FC1D;
	Thu,  8 Jul 2010 11:13:24 +0000 (UTC)
Received: from raven.net.t-labs.tu-berlin.de (raven.net.t-labs.tu-berlin.de
	[130.149.220.18])
	by mail.net.t-labs.tu-berlin.de (Postfix) with ESMTP id 3B4C1700038C;
	Thu,  8 Jul 2010 12:53:54 +0200 (CEST)
From: Alexandre Fiveg <alexandre@net.t-labs.tu-berlin.de>
Organization: t-net
To: Garrett Cooper <gcooper@freebsd.org>
Date: Thu, 8 Jul 2010 12:53:52 +0200
User-Agent: KMail/1.9.10
References: <201006112217.o5BMHtaQ086056@repoman.freebsd.org>
	<AANLkTikxGSuP9IzyUx4hR1INnX7o4QSAANzGMpW5FFH1@mail.gmail.com>
In-Reply-To: <AANLkTikxGSuP9IzyUx4hR1INnX7o4QSAANzGMpW5FFH1@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline
Message-Id: <201007081253.52947.alexandre@net.t-labs.tu-berlin.de>
Cc: Perforce Change Reviews <perforce@freebsd.org>,
	Alexandre Fiveg <afiveg@freebsd.org>
Subject: Re: PERFORCE change 179499 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 08 Jul 2010 11:13:25 -0000

On Saturday 12 June 2010 05:31:29 Garrett Cooper wrote:
> On Fri, Jun 11, 2010 at 3:17 PM, Alexandre Fiveg <afiveg@freebsd.org> wro=
te:
> > http://p4web.freebsd.org/@@179499?ac=3D10
> >
> > Change 179499 by afiveg@cottonmouth on 2010/06/11 22:16:54
> >
> > =A0 =A0 =A0 =A0em/Makefile cosmetic fix
> >
> > Affected files ...
> >
> > .. //depot/projects/soc2010/ringmap/current/sys/modules/em/Makefile#5
> > edit
> >
> > Differences ...
> >
> > =3D=3D=3D=3D //depot/projects/soc2010/ringmap/current/sys/modules/em/Ma=
kefile#5
> > (text+ko) =3D=3D=3D=3D
> >
> > @@ -1,5 +1,5 @@
> > =A0# $FreeBSD: src/sys/modules/em/Makefile,v 1.16 2010/03/29 23:36:34 j=
fv
> > Exp $ -.PATH: =A0${.CURDIR}/../../dev/e1000
> > +.PATH: =A0${.CURDIR}/../../dev/e1000 : ${.CURDIR}/../../net
>
> The colon is a syntax error, isn't it?
No, it is a deliminator
% man 1 make

Thanx,=20
Alex

>
> > =A0.if defined(KERNEL_RINGMAP)
> > =A0KMOD =A0 =3D if_ringmap
> > @@ -13,7 +13,7 @@
> >
> > =A0.if defined(KERNEL_RINGMAP)
> > =A0CFLAGS +=3D -D__RINGMAP__ -D__E1000_RINGMAP__
> > -SRCS =A0 =A0 =A0 =A0 =A0 +=3D ${.CURDIR}/../../net/ringmap.c
> > +SRCS =A0 =A0 =A0 =A0 =A0 +=3D ringmap.c
> > =A0.endif
> >
> > =A0CORE_SRC =3D if_em.c e1000_osdep.c
>
> Thanks,
> -Garrett