Date: Tue, 22 May 2012 20:07:20 -0700 From: Jason Helfman <jgh@FreeBSD.org> To: Bob Frazier <bobf@mrp3.com> Cc: ports@freebsd.org Subject: Re: [RFC] Seeking Approval: include bsd.port.pre.mk so SRC_BASE is defined before referenced Message-ID: <20120523030720.GA18894@dormouse.experts-exchange.com> In-Reply-To: <4FBC45AD.4080107@mrp3.com> References: <20120521220449.GD8317@dormouse.experts-exchange.com> <4FBC45AD.4080107@mrp3.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, May 22, 2012 at 07:04:29PM -0700, Bob Frazier thus spake: >On 05/21/12 15:04, Jason Helfman so wittily quipped: >> -----BEGIN PGP SIGNED MESSAGE----- >> Hash: SHA1 >> >> I am working on the following pr, and would like to get others approval to >> the following patch: >> http://people.freebsd.org/~jgh/files/pre-patch.txt >> >> http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/165994 >> >> This patch is fixing several use cases of SRC_BASE before it is defined. > >(re: comms/uarduno port) > >Now that I understand what the patch is for I totally agree, it should >be applied to comms/uarduno as well. I believe I copied my port from >one of the others that had the 'bad logic' in it, so thanks for catching it. > >Do I need to make the change or are you going to do it on your end? > Thanks so much! Committed. Still working through the list :) -jgh -- Jason Helfman FreeBSD Committer | http://people.freebsd.org/~jgh | The Power To Serve
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120523030720.GA18894>