Date: Wed, 30 May 2012 10:01:52 +0200 From: Marius Strobl <marius@alchemy.franken.de> To: Konstantin Belousov <kostikbel@gmail.com> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r236137 - head/contrib/gcc/config/i386 Message-ID: <20120530080151.GX90133@alchemy.franken.de> In-Reply-To: <20120530034747.GJ2358@deviant.kiev.zoral.com.ua> References: <201205270527.q4R5Rm44028055@svn.freebsd.org> <20120528190355.GA42283@alchemy.franken.de> <20120528204728.GD2358@deviant.kiev.zoral.com.ua> <20120529224833.GW90133@alchemy.franken.de> <20120530034747.GJ2358@deviant.kiev.zoral.com.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, May 30, 2012 at 06:47:47AM +0300, Konstantin Belousov wrote: > On Wed, May 30, 2012 at 12:48:33AM +0200, Marius Strobl wrote: > > On Mon, May 28, 2012 at 11:47:28PM +0300, Konstantin Belousov wrote: > > > On Mon, May 28, 2012 at 09:03:55PM +0200, Marius Strobl wrote: > > > > On Sun, May 27, 2012 at 05:27:48AM +0000, Konstantin Belousov wrote: > > > > > Author: kib > > > > > Date: Sun May 27 05:27:47 2012 > > > > > New Revision: 236137 > > > > > URL: http://svn.freebsd.org/changeset/base/236137 > > > > > > > > > > Log: > > > > > Enable gnu hash generation for dynamic ELF binaries on x86. > > > > > > > > > > > > > As far as I remember from your commit adding GNU hash support to > > > > rtld(1), there's nothing left to be done for the other architectures > > > > apart from testing, correct? > > > > > > Yes, you are correct. I am not aware of any non-implemented MD parts, > > > but I was unable to test on !x86, and got no feedback from arch maintainers. > > > > Sorry, must have missed that mail. > > What's the point of letting the linker create both the ELF and the > > GNU hash tables and not just going with the latter one? > > It prevents the flag day. If your binary is built on slightly newer system, > using both hashes allows it to be used on the system with slightly older > rtld, which was built before gnu hash support was added. Ehm, yes, but given that this wouldn't be the first such flag we have is avoiding it really worth the link time and run time overheads in the long term? Do you plan to change it to GNU hash only in HEAD at some point after MFC'ing? Marius
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120530080151.GX90133>