From owner-cvs-all@FreeBSD.ORG Tue Feb 19 20:01:18 2008 Return-Path: Delivered-To: cvs-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 74C6F16A4C9 for ; Tue, 19 Feb 2008 20:01:18 +0000 (UTC) (envelope-from marius@alchemy.franken.de) Received: from alchemy.franken.de (alchemy.franken.de [194.94.249.214]) by mx1.freebsd.org (Postfix) with ESMTP id 08EA113C4CC for ; Tue, 19 Feb 2008 20:01:17 +0000 (UTC) (envelope-from marius@alchemy.franken.de) Received: from alchemy.franken.de (localhost [127.0.0.1]) by alchemy.franken.de (8.14.1/8.14.1/ALCHEMY.FRANKEN.DE) with ESMTP id m1JK1GSI052567; Tue, 19 Feb 2008 21:01:16 +0100 (CET) (envelope-from marius@alchemy.franken.de) Received: (from marius@localhost) by alchemy.franken.de (8.14.1/8.14.1/Submit) id m1JK1Gew052566; Tue, 19 Feb 2008 21:01:16 +0100 (CET) (envelope-from marius) Date: Tue, 19 Feb 2008 21:01:16 +0100 From: Marius Strobl To: Doug Barton Message-ID: <20080219200116.GA37953@alchemy.franken.de> References: <200802182148.m1ILmv96094438@repoman.freebsd.org> <47BA016C.9080302@FreeBSD.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <47BA016C.9080302@FreeBSD.org> User-Agent: Mutt/1.4.2.3i Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/sysutils/cdrtools-devel Makefile pkg-plist ports/sysutils/cdrtools-devel/files patch-libsiconv-sic_nls.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Feb 2008 20:01:18 -0000 On Mon, Feb 18, 2008 at 02:06:36PM -0800, Doug Barton wrote: > Marius Strobl wrote: > >marius 2008-02-18 21:48:57 UTC > > > > FreeBSD ports repository (src committer) > > > > Modified files: > > sysutils/cdrtools-devel Makefile pkg-plist > > Added files: > > sysutils/cdrtools-devel/files patch-libsiconv-sic_nls.c > > Log: > > Fix `mkisofs -input-charset`: > > - The configure script adds dependencies on libiconv and libintl when > > found so set USE_GETTEXT and USE_ICONV accordingly. If these libraries > > are not yet installed, these dependencies can be turned off by defining > > WITHOUT_NLS. There's no easy way to force these dependencies off as > > the configure script doesn't offer such a knob and modifying its tests > > is not allowed. > > I'm confused, why is modifying the tests not allowed? In order to not need to remove the IS_SCHILY_XCONFIG macro, which makes our cdrtools port provide an inofficial version that is not supported by the author, which is something I'd like to avoid. /* * Begin restricted code for quality assurance. * * Warning: you are not allowed to include the #define below if you are not * using the Schily makefile system or if you modified the autoconfiguration * tests. * * If you only added other tests you are allowed to keep this #define. * * This restiction is introduced because this way, I hope that people * contribute to the project instead of creating branches. */ #define IS_SCHILY_XCONFIG /* * End restricted code for quality assurance. */ Marius