From owner-svn-src-all@freebsd.org Sat Jan 7 19:31:33 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 18B61CA4E95; Sat, 7 Jan 2017 19:31:33 +0000 (UTC) (envelope-from gnn@freebsd.org) Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net [IPv6:2001:4b98:c:538::195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id DC2F81A53; Sat, 7 Jan 2017 19:31:32 +0000 (UTC) (envelope-from gnn@freebsd.org) Received: from [192.168.0.162] (unknown [IPv6:2604:2000:8113:7200:e885:a241:9f9c:e4a6]) (Authenticated sender: gnn@neville-neil.com) by relay3-d.mail.gandi.net (Postfix) with ESMTPSA id 589D8A80C2; Sat, 7 Jan 2017 20:31:30 +0100 (CET) From: "George Neville-Neil" To: "Mark Johnston" Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r311225 - head/sys/netinet Date: Sat, 07 Jan 2017 14:31:28 -0500 Message-ID: In-Reply-To: <4C01D080-64D9-4862-AFD5-42CC49B5CC0B@freebsd.org> References: <201701040219.v042JDEk026544@repo.freebsd.org> <20170104182630.GA26522@wkstn-mjohnston.west.isilon.com> <4C01D080-64D9-4862-AFD5-42CC49B5CC0B@freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; format=flowed; markup=markdown X-Mailer: MailMate (1.9.6r5319) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 07 Jan 2017 19:31:33 -0000 On 7 Jan 2017, at 14:23, George Neville-Neil wrote: > On 4 Jan 2017, at 13:26, Mark Johnston wrote: > >> On Wed, Jan 04, 2017 at 02:19:13AM +0000, George V. Neville-Neil >> wrote: >>> Author: gnn >>> Date: Wed Jan 4 02:19:13 2017 >>> New Revision: 311225 >>> URL: https://svnweb.freebsd.org/changeset/base/311225 >>> >>> Log: >>> Fix DTrace TCP tracepoints to not use mtod() as it is both >>> unnecessary and >>> dangerous. Those wanting data from an mbuf should use DTrace >>> itself to get >>> the data. >> >> I think you also need to update the types in in_kdtrace.c, and add a >> translator for struct mbuf * to ipinfo_t. > > Fair points. > Actually, following up to myself, this does not need to be done just yet. The pkt_info stuff is currently always NULL. I'm working on a copyoutmbuf() subroutine that will make all of this much cleaner. Best, George