From owner-svn-src-all@FreeBSD.ORG Tue Oct 15 17:02:11 2013 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 5090852E for ; Tue, 15 Oct 2013 17:02:11 +0000 (UTC) (envelope-from freebsd@allanjude.com) Received: from mx1.scaleengine.net (beauharnois2.bhs1.scaleengine.net [142.4.218.15]) by mx1.freebsd.org (Postfix) with ESMTP id 2B4562740 for ; Tue, 15 Oct 2013 17:02:10 +0000 (UTC) Received: from [10.1.1.1] (S01060001abad1dea.hm.shawcable.net [50.70.108.129]) (Authenticated sender: allan.jude@scaleengine.com) by mx1.scaleengine.net (Postfix) with ESMTPSA id E85833CCB2; Tue, 15 Oct 2013 17:02:09 +0000 (UTC) Message-ID: <525D752E.6020901@allanjude.com> Date: Tue, 15 Oct 2013 13:02:38 -0400 From: Allan Jude User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.0.1 MIME-Version: 1.0 To: Adam McDougall , "Teske, Devin" Subject: Re: svn commit: r256343 - in head/usr.sbin/bsdinstall: . scripts References: <201310112041.r9BKfZeT002056@svn.freebsd.org> <20131015145032.GD98118@admin.xzibition.com> <13CA24D6AB415D428143D44749F57D720FC6A04C@LTCFISWMSGMB21.FNFIS.com> <525D5E07.1070900@allanjude.com> <13CA24D6AB415D428143D44749F57D720FC6A61F@LTCFISWMSGMB21.FNFIS.com> <20131015165820.GO2097@egr.msu.edu> In-Reply-To: <20131015165820.GO2097@egr.msu.edu> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: "svn-src-all@freebsd.org" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Oct 2013 17:02:11 -0000 On 2013-10-15 12:58, Adam McDougall wrote: > On Tue, Oct 15, 2013 at 04:28:21PM +0000, Teske, Devin wrote: > > >>>> +: ${ZFSBOOT_GNOP_4K_FORCE_ALIGN:=1} > >>>> > >>> > > >>> > > >>> I believe this trick is no longer needed after r254591. > >>> > > > > This may be the case, I am not sure if r254591 'always' fixes the problem, maybe someone else can weight in with a more definite yes/no > > > > I'll hold off on doing anything with 4K sectors gnop hack until > we get confirmation. > > r254591 says: > "Use GEOM's stripesize attribute, if set, as the physical sector size of the GEOM." > > I'm pretty sure GEOM only knows for a subset of devices, for example if the > kernel contains a quirk based on the drive model. If you are aiming for > performance, my 2 cents is to keep it. On the other hand, forcing 4k and thus > ashift=12 wastes more space in a zpool on a 512b device so it would be nice to > make this a toggle in the GUI defaulting to on. If it is already, I apologize, I > haven't tried the code in a few iterations. > > Yes, the gnop 4k section option is a toggle, which defaults to on. -- Allan Jude