Date: Sun, 24 Sep 1995 15:13:14 -0400 From: john@jwlab.feith.com (John Wehle) Subject: Patch to FreeBSD 2.1 SoundMan Wave device driver Message-ID: <9509241913.AA03210@jwlab.FEITH.COM>
next in thread | raw e-mail | index | archive | help
Hello,
This is a patch to correct a couple of problems with the SoundMan Wave
device driver.
1) Looking at sb_dsp.c it appears that if SMW_MIDI0001_INCLUDED
is not defined then junk is downloaded into the microcode ram.
This patch changes the code so that no microcode is downloaded
if SMW_MIDI0001_INCLUDED is not defined.
2) There wasn't a default setting supplied for JAZZ_DMA16 (which
is needed to support the SoundMan Wave) so as a simple nicety
this patch adds a default to sound_config.h.
3) It would be nice if defining SM_WAVE automatically defined JAZZ16
since the JAZZ16 code is required in order to support the SoundMan
Wave. This issue isn't addressed by this patch since I wasn't
sure of the convention in use for handling this type of issue.
Other then that the driver seems to work well with my SoundMan Wave.
Sincerely,
John Wehle
john@feith.com
------------------8<------------------------8<------------------------
*** /sys/i386/isa/sound/sb_dsp.c.orig Thu Sep 14 22:45:03 1995
--- /sys/i386/isa/sound/sb_dsp.c Sun Sep 24 14:05:29 1995
***************
*** 902,911 ****
{
#ifdef SMW_MIDI0001_INCLUDED
#include "smw-midi0001.h"
- #else
- unsigned char smw_ucode[1];
- int smw_ucodeLen = 0;
-
#endif
int mp_base = MPU_BASE + 4; /* Microcontroller base */
--- 902,907 ----
***************
*** 949,955 ****
printk ("\nSM Wave: Invalid microcode (MIDI0001.BIN) length\n");
return 1;
}
- #endif
/*
* Download microcode
--- 945,950 ----
***************
*** 968,973 ****
--- 963,969 ----
printk ("SM Wave: Microcode verification failed\n");
return 0;
}
+ #endif
control = 0;
#ifdef SMW_SCSI_IRQ
*** /sys/i386/isa/sound/sound_config.h.orig Thu Sep 14 22:45:06 1995
--- /sys/i386/isa/sound/sound_config.h Sun Sep 24 14:14:07 1995
***************
*** 90,95 ****
--- 90,99 ----
#define SBC_DMA 1
#endif
+ #ifndef JAZZ_DMA16
+ #define JAZZ_DMA16 5
+ #endif
+
#ifndef SB16_DMA
#define SB16_DMA 6
#endif
-------------------------------------------------------------------------
| Feith Systems | Voice: 1-215-646-8000 | Email: john@feith.com |
| John Wehle | Fax: 1-215-540-5495 | |
-------------------------------------------------------------------------
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?9509241913.AA03210>