From owner-freebsd-current@FreeBSD.ORG Sat Aug 25 12:37:56 2007 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2E4F616A417 for ; Sat, 25 Aug 2007 12:37:56 +0000 (UTC) (envelope-from peterjeremy@optushome.com.au) Received: from turion.vk2pj.dyndns.org (c220-239-20-82.belrs4.nsw.optusnet.com.au [220.239.20.82]) by mx1.freebsd.org (Postfix) with ESMTP id A5A2113C469 for ; Sat, 25 Aug 2007 12:37:55 +0000 (UTC) (envelope-from peterjeremy@optushome.com.au) Received: from turion.vk2pj.dyndns.org (localhost.vk2pj.dyndns.org [127.0.0.1]) by turion.vk2pj.dyndns.org (8.14.1/8.14.1) with ESMTP id l7PCbsQc018737; Sat, 25 Aug 2007 22:37:54 +1000 (EST) (envelope-from peter@turion.vk2pj.dyndns.org) Received: (from peter@localhost) by turion.vk2pj.dyndns.org (8.14.1/8.14.1/Submit) id l7PCbsfN018736; Sat, 25 Aug 2007 22:37:54 +1000 (EST) (envelope-from peter) Date: Sat, 25 Aug 2007 22:37:54 +1000 From: Peter Jeremy To: Kostik Belousov Message-ID: <20070825123754.GM17244@turion.vk2pj.dyndns.org> References: <20070817073321.GA6321@turion.vk2pj.dyndns.org> <20070821144303.GD2738@deviant.kiev.zoral.com.ua> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="M9NhX3UHpAaciwkO" Content-Disposition: inline In-Reply-To: <20070821144303.GD2738@deviant.kiev.zoral.com.ua> X-PGP-Key: http://members.optusnet.com.au/peterjeremy/pubkey.asc User-Agent: Mutt/1.5.16 (2007-06-09) Cc: freebsd-current@freebsd.org, tegge@freebsd.org Subject: Re: insmntque for syncvnode panic [Was: Re: panic unmounting filesystems] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 25 Aug 2007 12:37:56 -0000 --M9NhX3UHpAaciwkO Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 2007-Aug-21 17:43:03 +0300, Kostik Belousov wrote: >> The mountpoint shows as in the process of being unmounted and has >> mnt_nvnodelistsize =3D=3D 0 so insmntque() makes sense at the micro leve= l. >> Having a system panic as a result does not make sense. >Sure. I think that syncvnode shall be allocated after the MNTK_UNMOUNT >flag is cleared. > >Could you, please, test the patch below ? >diff --git a/sys/kern/vfs_mount.c b/sys/kern/vfs_mount.c >index 702efc3..09f4d1e 100644 This appears to have resolved the problem - after adding the patch, I've been unable to get umount to panic. Thanks for the fix. --=20 Peter Jeremy --M9NhX3UHpAaciwkO Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (FreeBSD) iD8DBQFG0CKi/opHv/APuIcRArufAJ90mcntnnYsCGZJp/+25kf2PoTjdACfWka4 s3+yM9g6hYlfC7eSkZeleFY= =z5Ih -----END PGP SIGNATURE----- --M9NhX3UHpAaciwkO--