From owner-svn-src-head@freebsd.org Wed Jun 10 00:13:16 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id F3FB0341AB3; Wed, 10 Jun 2020 00:13:15 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 49hSBM6GFNz47Cy; Wed, 10 Jun 2020 00:13:15 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from mail-qt1-f181.google.com (mail-qt1-f181.google.com [209.85.160.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) (Authenticated sender: kevans) by smtp.freebsd.org (Postfix) with ESMTPSA id D1E142BA15; Wed, 10 Jun 2020 00:13:15 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: by mail-qt1-f181.google.com with SMTP id g62so440287qtd.5; Tue, 09 Jun 2020 17:13:15 -0700 (PDT) X-Gm-Message-State: AOAM532LjqKsYkShOtsUg2bji0Ad+zIKjb+xPw+Z/P5vTp460bXWxs+R PrFkuJo9l3H+E6mO+R2HJN+0mUJOfiMtjpZIxMw= X-Google-Smtp-Source: ABdhPJzYF13Chg8vQnIEAvx4cfaOEy5VqgJepNk5YPVkUh7t/GxSQ54vhajDhUFiw+TTJT616eowispOAxIzTLKJKlc= X-Received: by 2002:aed:3169:: with SMTP id 96mr504504qtg.211.1591747995207; Tue, 09 Jun 2020 17:13:15 -0700 (PDT) MIME-Version: 1.0 References: <202006100009.05A09VkH082752@repo.freebsd.org> In-Reply-To: <202006100009.05A09VkH082752@repo.freebsd.org> From: Kyle Evans Date: Tue, 9 Jun 2020 19:13:04 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r361994 - in head/sys/mips: cavium/cryptocteon nlm/dev/sec To: John Baldwin Cc: src-committers , svn-src-all , svn-src-head Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Jun 2020 00:13:16 -0000 On Tue, Jun 9, 2020 at 7:09 PM John Baldwin wrote: > > Author: jhb > Date: Wed Jun 10 00:09:31 2020 > New Revision: 361994 > URL: https://svnweb.freebsd.org/changeset/base/361994 > > Log: > Add some default cases for unreachable code to silence compiler warnings. > > This was caused by r361481 when the buffer type was changed from an > int to an enum. > > Reported by: mjg, rpokala > Sponsored by: Chelsio Communications > > Modified: > head/sys/mips/cavium/cryptocteon/cryptocteon.c > head/sys/mips/nlm/dev/sec/nlmseclib.c > > Modified: head/sys/mips/cavium/cryptocteon/cryptocteon.c > ============================================================================== > --- head/sys/mips/cavium/cryptocteon/cryptocteon.c Tue Jun 9 23:03:48 2020 (r361993) > +++ head/sys/mips/cavium/cryptocteon/cryptocteon.c Wed Jun 10 00:09:31 2020 (r361994) > @@ -323,6 +323,8 @@ cryptocteon_process(device_t dev, struct cryptop *crp, > goto done; > } > break; > + default: > + break; > } > > if (csp->csp_cipher_alg != 0) { > This one could kind of looks like it should also be an __assert_unreachable(), and perhaps this bit not too long later: case CRYPTO_BUF_CONTIG: iovlen = crp->crp_buf.cb_buf_len; od->octo_iov[0].iov_base = crp->crp_buf.cb_buf; od->octo_iov[0].iov_len = crp->crp_buf.cb_buf_len iovcnt = 1; break; default: - panic("can't happen"); + __assert_unreachable(); }