From owner-freebsd-python@freebsd.org Mon Jul 31 16:40:37 2017
Return-Path: <owner-freebsd-python@freebsd.org>
Delivered-To: freebsd-python@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
[IPv6:2001:1900:2254:206a::19:1])
by mailman.ysv.freebsd.org (Postfix) with ESMTP id 733DBDB3DF0;
Mon, 31 Jul 2017 16:40:37 +0000 (UTC)
(envelope-from araujobsdport@gmail.com)
Received: from mail-vk0-x22f.google.com (mail-vk0-x22f.google.com
[IPv6:2607:f8b0:400c:c05::22f])
(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
(Client CN "smtp.gmail.com",
Issuer "Google Internet Authority G2" (verified OK))
by mx1.freebsd.org (Postfix) with ESMTPS id 22F9683659;
Mon, 31 Jul 2017 16:40:37 +0000 (UTC)
(envelope-from araujobsdport@gmail.com)
Received: by mail-vk0-x22f.google.com with SMTP id d124so18251690vkf.2;
Mon, 31 Jul 2017 09:40:37 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
h=mime-version:reply-to:in-reply-to:references:from:date:message-id
:subject:to:cc;
bh=zzMA3MRNPqPzw1BmEGgZ4Po0cCwoyUcodC3rHRtsd4c=;
b=u2NEtAqockSZCLJmq2UraxyKJoK/G38TTde1ZHUII7YNDZ1lqdWPVVXzb1oXh+Js/V
3Ju8Wx2mgnU150683URv3WVgAjTSxd+aUu9T5+QFopL0BYnGr/6GtW0qhnyvCWHa9dmG
TQWbKgOyNekATgEWqxh9DzPLFIuNLLz+upHY8wXCD1Uziut+T2+8q9KlfOnFNWpATMz5
N6HeMWmunSV/XfQi58ELvrdenex7eiwREzmVwvXiXZSFkvQKuFAqxDrLd2E7WwgY/mZF
OswA1gA0XKSsNV4PX2blBHM9sycIoLOq5ULfgd4+PETNpdLWJpt7hnKB421Y1vksTOnS
f8ZQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:mime-version:reply-to:in-reply-to:references
:from:date:message-id:subject:to:cc;
bh=zzMA3MRNPqPzw1BmEGgZ4Po0cCwoyUcodC3rHRtsd4c=;
b=Za/r5Ct+GHzabUKdQO2Q8KphiKAQnlkmt1CXnPOVGVW0Xb/0aQ/1uRZj5vksVHjYES
O6kxpT3sbJD1w7Z/ozMPlLHGPcjXmN8I9nYF4pOumrw7B7H+8In3jGNpNVAaQYv2Twdx
YbVuB4bxDaAUjeFuKufFAXkvHGFh1AsssljnLsUf/M70anfVM2Sjj1dOVtimkzyWD0md
f1vaMQN3WjX/L40fTRwm0hCFZ3GxoAf46Nx9pH6+qFRWQTWEoRCNrsqUD19iNSkJhP1B
BsTgO0G5YWvVsx/s+L2Bz8pAwhGpQ32Yn1sgQQIiA/S732mmnyl7bdqtET3e4J2xUBR/
93Mw==
X-Gm-Message-State: AIVw110DD97rwtvalZMwcmiZJXPHnid7FKGSR8uVxKHNy2IXVQSUbn8i
zRDNNuAgGbSQBQHBMmHiCsJqQgGe8w==
X-Received: by 10.31.81.195 with SMTP id f186mr10045270vkb.119.1501519236073;
Mon, 31 Jul 2017 09:40:36 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.176.6.42 with HTTP; Mon, 31 Jul 2017 09:40:35 -0700 (PDT)
Reply-To: araujo@freebsd.org
In-Reply-To: <e255b7da-f9e9-370d-3183-5538ca9e35c2@FreeBSD.org>
References: <201707290417.v6T4HWGX048404@repo.freebsd.org>
<98CDBA25-758F-4C2E-9A25-426B9DEEACBF@adamw.org>
<CAOfEmZjCUYDfb+_6okRCbyTeSLgLWLaXF0V9jF+n=h1g2vS_Lg@mail.gmail.com>
<22e402da-53de-3418-e3d9-9777cd35f778@FreeBSD.org>
<CAOfEmZiOY3ej9N0jwFqdOOXWYdNpnMqmLuzXN+ScHz9zhr=gJw@mail.gmail.com>
<20170731100728.frov3ttvs3qyxsm7@ivaldir.net>
<0dd92f7f-5f3e-19df-acb8-c1d74f7c4d92@FreeBSD.org>
<e255b7da-f9e9-370d-3183-5538ca9e35c2@FreeBSD.org>
From: Marcelo Araujo <araujobsdport@gmail.com>
Date: Tue, 1 Aug 2017 00:40:35 +0800
Message-ID: <CAOfEmZg58MyO70-=+tbC1w48YGU50J-V-vHvcU-DQmDvfu_y5w@mail.gmail.com>
Subject: Re: svn commit: r446864 - head/sysutils/py3-iocage
To: Bryan Drewery <bdrewery@freebsd.org>
Cc: koobs@freebsd.org, Baptiste Daroussin <bapt@freebsd.org>,
Adam Weinberger <adamw@adamw.org>,
ports-committers <ports-committers@freebsd.org>,
"svn-ports-all@freebsd.org" <svn-ports-all@freebsd.org>,
"svn-ports-head@freebsd.org" <svn-ports-head@freebsd.org>,
FreeBSD Python Team <freebsd-python@freebsd.org>,
"portmgr@FreeBSD.org" <portmgr@freebsd.org>
Content-Type: text/plain; charset="UTF-8"
X-Content-Filtered-By: Mailman/MimeDel 2.1.23
X-BeenThere: freebsd-python@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: FreeBSD-specific Python issues <freebsd-python.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-python>,
<mailto:freebsd-python-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-python/>
List-Post: <mailto:freebsd-python@freebsd.org>
List-Help: <mailto:freebsd-python-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-python>,
<mailto:freebsd-python-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 31 Jul 2017 16:40:37 -0000
2017-08-01 0:26 GMT+08:00 Bryan Drewery <bdrewery@freebsd.org>:
> On 7/31/2017 3:28 AM, Kubilay Kocak wrote:
> > On 7/31/17 8:07 PM, Baptiste Daroussin wrote:
> >> On Mon, Jul 31, 2017 at 05:03:35PM +0800, Marcelo Araujo wrote:
> >>> 2017-07-31 10:35 GMT+08:00 Kubilay Kocak <koobs@freebsd.org>:
> >>>
> >>>> On 7/31/17 11:16 AM, Marcelo Araujo wrote:
> >>>>>
> >>>>>
> >>>>> 2017-07-30 21:18 GMT+08:00 Adam Weinberger <adamw@adamw.org
> >>>>> <mailto:adamw@adamw.org>>:
> >>>>>
> >>>>> > On 28 Jul, 2017, at 22:17, Marcelo Araujo <araujo@freebsd.org
> >>>>> <mailto:araujo@freebsd.org>> wrote:
> >>>>> >
> >>>>> > Author: araujo
> >>>>> > Date: Sat Jul 29 04:17:31 2017
> >>>>> > New Revision: 446864
> >>>>> > URL: https://svnweb.freebsd.org/changeset/ports/446864
> >>>>> <https://svnweb.freebsd.org/changeset/ports/446864>
> >>>>> >
> >>>>> > Log:
> >>>>> > - Update to 0.9.9.
> >>>>> >
> >>>>> > Changelog at: https://github.com/iocage/
> iocage/releases/tag/0.9.9
> >>>>> <https://github.com/iocage/iocage/releases/tag/0.9.9>
> >>>>> >
> >>>>> > Modified:
> >>>>> > head/sysutils/py3-iocage/Makefile
> >>>>> > head/sysutils/py3-iocage/distinfo
> >>>>> >
> >>>>> > Modified: head/sysutils/py3-iocage/Makefile
> >>>>> >
> >>>>> ============================================================
> >>>> ==================
> >>>>> > --- head/sysutils/py3-iocage/Makefile Sat Jul 29 04:00:56 2017
> >>>>> (r446863)
> >>>>> > +++ head/sysutils/py3-iocage/Makefile Sat Jul 29 04:17:31 2017
> >>>>> (r446864)
> >>>>> > @@ -1,7 +1,7 @@
> >>>>> > # $FreeBSD$
> >>>>> >
> >>>>> > PORTNAME= iocage
> >>>>> > -PORTVERSION= 0.9.8.1
> >>>>> > +PORTVERSION= 0.9.9
> >>>>> > CATEGORIES= sysutils python
> >>>>> > PKGNAMEPREFIX= ${PYTHON_PKGNAMEPREFIX}
> >>>>> >
> >>>>> > @@ -15,6 +15,7 @@ BUILD_DEPENDS=
> >>>>> ${PYTHON_PKGNAMEPREFIX}pytest-runner>=2
> >>>>> > RUN_DEPENDS= ${PYTHON_PKGNAMEPREFIX}click>=6.7:devel/py3-click
> \
> >>>>> > ${PYTHON_PKGNAMEPREFIX}tqdm>=4.10.0:misc/py3-tqdm
> \
> >>>>> >
> >>>>> ${PYTHON_PKGNAMEPREFIX}coloredlogs>0:devel/py3-coloredlogs \
> >>>>> > +
> >>>>> ${PYTHON_PKGNAMEPREFIX}verboselogs>0:devel/py-verboselogs \
> >>>>> > ca_root_nss>0:security/ca_root_nss \
> >>>>> >
> >>>>> ${PYTHON_PKGNAMEPREFIX}texttable>=0.8.7:textproc/py3-texttable
> \
> >>>>> >
> >>>>> ${PYTHON_PKGNAMEPREFIX}pytest-runner>=2.0.0:devel/py3-
> pytest-runner
> >>>>>
> >>>>> Hi Marcelo,
> >>>>>
> >>>>> There is no py36-verboselogs package. You'll need to create a
> >>>>> py3-verboselogs port, because right now only py27-verboselogs
> gets
> >>>>> built.
> >>>>>
> >>>>> See the build failure at
> >>>>> http://beefy10.nyi.freebsd.org/data/110i386-default/
> >>>> 446906/logs/py36-iocage-0.9.9.log
> >>>>> <http://beefy10.nyi.freebsd.org/data/110i386-default/
> >>>> 446906/logs/py36-iocage-0.9.9.log>
> >>>>>
> >>>>> # Adam
> >>>>>
> >>>>>
> >>>>> --
> >>>>> Adam Weinberger
> >>>>> adamw@adamw.org <mailto:adamw@adamw.org>
> >>>>> https://www.adamw.org
> >>>>>
> >>>>>
> >>>>> Hi,
> >>>>>
> >>>>> We can't add py3 ports because soon we gonna have FLAVORS!
> >>>>> I can build iocage if I define the python version on my make.conf,
> >>>>> however I can see the issue with poudriere.
> >>>>
> >>>> Since this port already uses py3-* (workaround) ports for dependencies
> >>>> and there is no known ETA for VARIANTS support in ports, and the port
> is
> >>>> broken without py3-verboselogs, it should be created.
> >>>>
> >>>> Also, py-iocage should be resurrected, py-iocage was incorrectly
> deleted
> >>>> [1] instead of this one when it moved to Python 3.x only support.
> py3-*
> >>>> ports are only for (temporary) dependencies
> >>>>
> >>>> [1] http://svnweb.freebsd.org/changeset/ports/445459
> >>>
> >>>
> >>> How I can pass the pre-commit hook that blocks any add of py3 slave
> ports?
> >>>
> >>> Best,
> >>>
> >>
> >> FLAVORS are in review and finished, poudriere is able to deal with them
> -devel.
> >>
> >> The commit is pending exp-run, documentation etc. It takes time as it
> is a major
> >> change in the framework with huge impact.
> >>
> >> py3-* were a hack in the first place that should never have been done,
> they
> >> addition made it more complicated to work on FLAVORS, adding more and
> by passing
> >> the hook would just give even more delay for FLAVORS to be committed.
> >
> >> Best regards,
> >> Bapt
> >>
> >
> > Existing ports (particularly popular ports like iocage) that already
> > rely on these dependencies should be allowed continue to work. The block
> > relies on the assumption that new dependencies for existing and working
> > ports will never be needed, which is the case here.
> >
> > The block on new py3-* ports (while noone likes them) was and is
> > premature, and is even more so without an alternative, and it was
> > heavy-handed. Developers were already trying hard to minimise their use.
> >
> > The block should be removed, and can be re-added when the official
> > package builders are running with the poudriere "special feature"
> > version that builds py3-* versions of py- ports automatically, or ports
>
> I'm not quite awake yet so pardon the terseness. I will start a
> poudriere-devel exp-run now and then push it out to the builders
> following that in the next 2 days. That will allow py3- dependencies to
> build properly. It would allow existing py3- leaf ports to build as well.
>
> As for py3- leaf ports I would allow them but they have to follow strict
> criteria:
> - They must be named category/py3-foo
> - They must be a *slave* port to a category/py-foo
> - They must be supported on all python versions, not just 3.4+ or
> something odd like that.
>
> The FLAVORS support in Poudriere is done. What is held up is an exp-run
> that I'm tasked with and various bugs/documentation/more exp-runs.
> Every new py3- port added that doesn't follow those rules means we have
> to change Poudriere again. I think the criteria above is reasonable but
> I know the last one is problematic.
>
> I've said on IRC before but not sure I have here, that py3- ports beyond
> the fixed cases above, are only useful for generating a leaf package for
> users to download. They can still build category/py-foo as PYTHON3
> today though. So there is an alternative but it is just not
> package-friendly yet.
>
> About the block being premature, I will agree that what was lacking was
> a communication about it to a wider community and an override allowed
> with Portmgr review. At the time I wasn't quite sure what the criteria
> for an override would even be. Now that I understand it more and have
> Poudriere being a bit smarter than my first implementation, I will tweak
> the block to allow a Portmgr override.
>
> > variants supports lands, whichever one comes first. If that's in 3 days,
> > great, if its in 3 weeks or 2 months, our developers have been allowed
> > to keep the status quo working.
> >
> > Users are currently being impacted where there is no alternative and
> > they should not be asked to pay that price for our dislike of py3-*
> ports.
> >
> > Best regards,
> > Koobs
> >
>
>
> --
> Regards,
> Bryan Drewery
>
>
Thank you! I did open the review for the inclusion of py3-verboselogs.
Best,
--
--
Marcelo Araujo (__)araujo@FreeBSD.org
\\\'',)http://www.FreeBSD.org <http://www.freebsd.org/> \/ \ ^
Power To Server. .\. /_)